Bug 246750 - ZFS: Confusing error message when creating ZFS pool on vdev
Summary: ZFS: Confusing error message when creating ZFS pool on vdev
Status: New
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-fs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-26 12:13 UTC by Mateusz Kwiatkowski
Modified: 2020-05-29 01:24 UTC (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mateusz Kwiatkowski 2020-05-26 12:13:16 UTC
On default FreeBSD configuration (vfs.zfs.vol.recursive == 0) it's impossible to create ZFS pools on vdevs. When users try to do this they see generic and confusing error message:

```
# zfs create -V 1G -s zroot/kwiat
# zpool create -f kwiat /dev/zvol/zroot/kwiat
cannot create 'kwiat': no such pool or dataset
```

For someone not experienced in ZFS it will take some time to learn how to workaround this as it seems it's not documented anywhere. What's more, on Linux it just works.

My ideas how to improve this:

1) Better error message when vfs.zfs.vol.recursive==0 and backing device is zvol.
Example: "cannot create 'kwiat': creating pool on zvol is dangerous. See man zpool(8) for more info."

2) Document it in the zpool(8) manpage in "zpool create" section
Comment 1 Mateusz Kwiatkowski 2020-05-26 18:57:38 UTC
After reboot, pool on zvol cannot be imported even with vfs.zfs.vol.recursive=1. zpool import command hangs indefinitely and ignores ^C. 

Output of procstat -k of that process:
  PID    TID COMM                TDNAME              KSTACK
 49700 102119 zpool               -                   mi_switch sleepq_switch _sx_xlock_hard _sx_xlock spa_all_configs zfs_ioc_pool_configs zfsdev_ioctl devfs_ioctl vn_ioctl devfs_ioctl_f kern_ioctl sys_ioctl amd64_syscall fast_syscall_common
Comment 2 Andriy Gapon freebsd_committer 2020-05-27 06:45:28 UTC
(In reply to Mateusz Kwiatkowski from comment #1)
That kind of a hang is exactly why vfs.zfs.vol.recursive is zero by default.
Comment 3 Mateusz Kwiatkowski 2020-05-27 07:47:11 UTC
(In reply to Andriy Gapon from comment #2)
That's my guess too. UX could be better either way.