Bug 246785 - sysutils/smartmontools: periodic script should always alert about failing disks
Summary: sysutils/smartmontools: periodic script should always alert about failing disks
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Oleksii Samorukov
URL:
Keywords: buildisok
Depends on:
Blocks:
 
Reported: 2020-05-27 14:55 UTC by Alan Somers
Modified: 2020-06-11 14:04 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (samm)


Attachments
Raises attention level of periodic output for failing disks (902 bytes, patch)
2020-05-27 14:55 UTC, Alan Somers
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alan Somers freebsd_committer 2020-05-27 14:55:35 UTC
Created attachment 214924 [details]
Raises attention level of periodic output for failing disks

Periodic scripts should return rc=1 for informational messages.  For matters
that require urgent attention, then should return rc=3 (or greater).  A
SMART imminent failure prediction requires urgent attention, so it should
return rc=3.
Comment 1 Automation User 2020-06-11 13:33:57 UTC
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/155261438
Comment 2 commit-hook freebsd_committer 2020-06-11 14:04:15 UTC
A commit references this bug:

Author: asomers
Date: Thu Jun 11 14:04:01 UTC 2020
New revision: 538488
URL: https://svnweb.freebsd.org/changeset/ports/538488

Log:
  sysutils/smartmontools: periodic should always alert about failing disks

  Periodic scripts should return rc=1 for informational messages.  For matters
  that require urgent attention, then should return rc=3 (or greater).  A
  SMART imminent failure prediction requires urgent attention, so it should
  return rc=3.

  PR:		246785
  Approved by:	samm (maintainer timeout)
  Sponsored by:	Axcient

Changes:
  head/sysutils/smartmontools/Makefile
  head/sysutils/smartmontools/files/smart.in