Bug 246794 - games/libretro-uae: Fix i386 build
Summary: games/libretro-uae: Fix i386 build
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Fernando Apesteguía
URL:
Keywords: buildisok
Depends on:
Blocks:
 
Reported: 2020-05-28 02:50 UTC by Daniel Menelkir
Modified: 2020-05-29 12:11 UTC (History)
1 user (show)

See Also:


Attachments
libretro-uae-v1.diff (1.33 KB, patch)
2020-05-28 02:50 UTC, Daniel Menelkir
menelkir: maintainer-approval+
Details | Diff
Fix build in i386 (1.22 KB, patch)
2020-05-28 14:07 UTC, Fernando Apesteguía
fernape: maintainer-approval?
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Menelkir 2020-05-28 02:50:19 UTC
Created attachment 214945 [details]
libretro-uae-v1.diff

I was seeing the logs of poudriere and it seems i386 is failing to build properly. So I think it's better to drop i386 support for now.
Comment 1 Automation User 2020-05-28 03:11:38 UTC
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/150331204
Comment 2 Fernando Apesteguía freebsd_committer 2020-05-28 08:54:47 UTC
Thanks for the patch. After running portlint -AC

$ portlint -AC
FATAL: Makefile: [12]: use a tab (not space) after a variable name
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
1 fatal error and 1 warning found.

No need to upload a new patch. Just try to run portlint -AC on the port you modify :-)
Comment 3 Fernando Apesteguía freebsd_committer 2020-05-28 12:04:32 UTC
Having a look at the patch,

Wouldn't it be better to mark it BROKEN in i386 instead of trying to use an explicit list or archs?
Comment 4 Fernando Apesteguía freebsd_committer 2020-05-28 14:07:17 UTC
Created attachment 214966 [details]
Fix build in i386

This patch fixes the build in i386.

Would you try it?
Comment 5 Daniel Menelkir 2020-05-28 19:54:52 UTC
(In reply to Fernando Apesteguía from comment #4)

I don't know, I didn't had enough tests to sau that, but it didn't manually build it. So I'm not really sure.
Comment 6 Fernando Apesteguía freebsd_committer 2020-05-28 20:50:34 UTC
(In reply to Daniel Menelkir from comment #5)

But can you try this patch and confirm it builds? And if you have an i386, can you give it a try as in run test it?
Comment 7 commit-hook freebsd_committer 2020-05-29 12:10:43 UTC
A commit references this bug:

Author: fernape
Date: Fri May 29 12:09:48 UTC 2020
New revision: 536968
URL: https://svnweb.freebsd.org/changeset/ports/536968

Log:
  games/libretro-uae: update to 0.20200527

  While here, fix build in i386

  PR:	246794
  Reported by:	menelkir@itroll.org (maintainer)

Changes:
  head/games/libretro-uae/Makefile
  head/games/libretro-uae/distinfo
Comment 8 Fernando Apesteguía freebsd_committer 2020-05-29 12:11:52 UTC
I consider it is safe to commit this,

Thanks!