Bug 246813 - [NEW PORT] databases/py-txredisapi: A non-blocking redis client for python
Summary: [NEW PORT] databases/py-txredisapi: A non-blocking redis client for python
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Bernhard Froehlich
URL:
Keywords:
Depends on:
Blocks: 246814
  Show dependency treegraph
 
Reported: 2020-05-28 16:20 UTC by Sascha Biberhofer
Modified: 2020-06-02 19:14 UTC (History)
1 user (show)

See Also:


Attachments
databases/py-txredisapi: Add new port (2.92 KB, patch)
2020-05-28 16:20 UTC, Sascha Biberhofer
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sascha Biberhofer 2020-05-28 16:20:47 UTC
Created attachment 214980 [details]
databases/py-txredisapi: Add new port

databases/py-txredisapi: Add py-txredisapi to ports

py-txredisapi[1] is a redis client for python using py-twisted for database connections. My primary motivation for adding this port is that net-im/py-matrix-synapse relies on it for redis connections.

portlint: OK (looks fine.)
testport: OK (poudriere: 121amd64)
do-test: FAIL (skips=7, errors=1, successes=157)

The testsuit failure is due to a problem with the teardown of a test:


[ERROR]
Traceback (most recent call last):
Failure: twisted.trial.util.DirtyReactorAggregateError: Reactor was unclean.
DelayedCalls: (set twisted.internet.base.DelayedCall.debug = True to debug)
<DelayedCall 0x803889790 [0.9998748302459717s] called=0 cancelled=0 Sentinel.discover_master.<locals>.on_timeout()>

tests.test_sentinel.TestConnectViaSentinel.test_drop_all_when_master_changes
-------------------------------------------------------------------------------
Ran 165 tests in 50.269s


It appears that this type of error is a common occurence with trial testsuites and points to a bug in the teardown of the tests themselves, but I couldn't see an easy way to fix this as I have no experience with twisted.

Feedback is, as always, very much welcome and appreciated.

Cheers,
Sascha

[1] https://github.com/IlyaSkriblovsky/txredisapi
Comment 1 Bernhard Froehlich freebsd_committer 2020-05-28 20:18:40 UTC
I'll take it
Comment 2 Bernhard Froehlich freebsd_committer 2020-06-02 19:14:07 UTC
Committed. Thanks!
Comment 3 commit-hook freebsd_committer 2020-06-02 19:14:28 UTC
A commit references this bug:

Author: decke
Date: Tue Jun  2 19:13:49 UTC 2020
New revision: 537569
URL: https://svnweb.freebsd.org/changeset/ports/537569

Log:
  txredisapi is a non-blocking client driver for the redis database, written in
  python. It uses twisted for the asynchronous communication with redis.

  WWW: https://github.com/IlyaSkriblovsky/txredisapi

  PR:		246813
  Submitted by:	Sascha Biberhofer <ports@skyforge.at>

Changes:
  head/databases/Makefile
  head/databases/py-txredisapi/
  head/databases/py-txredisapi/Makefile
  head/databases/py-txredisapi/distinfo
  head/databases/py-txredisapi/pkg-descr