Bug 246904 - mail/cyrus-imapd32: fix Running Q/A tests (stage-qa) and fix a LIB_DEPENDS
Summary: mail/cyrus-imapd32: fix Running Q/A tests (stage-qa) and fix a LIB_DEPENDS
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Hajimu UMEMOTO
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-06-01 08:24 UTC by thomas
Modified: 2020-06-01 13:01 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (ume)


Attachments
cyrus-impad32 Makefile diff (1.56 KB, patch)
2020-06-01 08:24 UTC, thomas
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description thomas 2020-06-01 08:24:26 UTC
Created attachment 215123 [details]
cyrus-impad32 Makefile diff

Hello

When I try to compile cyrus-imap32 (3.2.1) i see multiple warnings and errors listed below.

My system:
FreeBSD 12.1-RELEASE-p5 GENERIC  amd64
/etc/make.conf:
LOADER_ZFS_SUPPORT=YES
WITHOUT_X11=yes
DEVELOPER=yes
DEFAULT_VERSIONS+=ssl=openssl

/etc/src.conf is empty

/etc/sysctl.conf:
security.bsd.stack_guard_page=1


Error message during port compile with default port options:
Error: '/usr/bin/perl' is an invalid shebang you need USES=shebangfix for 'cyrus/sbin/masssievec'
Error: '/usr/bin/perl' is an invalid shebang you need USES=shebangfix for 'bin/sieveshell'
Warning: 'lib/libcyrus_imap.so.0.0.0' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD}
Warning: 'lib/libcyrus_com_err.so.0.0.0' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD}
Warning: 'lib/perl5/site_perl/mach/5.30/auto/Cyrus/IMAP/IMAP.so' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD}
Warning: 'lib/perl5/site_perl/mach/5.30/auto/Cyrus/SIEVE/managesieve/managesieve.so' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD}
Warning: 'lib/libcyrus_min.so.0.0.0' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD}
Warning: 'lib/libcyrus_sieve.so.0.0.0' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD}
Warning: 'lib/libcyrus.so.0.0.0' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD}
Error: /usr/local/lib/libcyrus_imap.so.0.0.0 is linked to /usr/local/lib/libuuid.so.1 from misc/e2fsprogs-libuuid but it is not declared as a dependency
Warning: you need LIB_DEPENDS+=libuuid.so:misc/e2fsprogs-libuuid
*** Error code 1

Possible fixes I've added to a new Makefile:
I modified the Makefile to add:
LIB_DEPENDS libuuid.so:misc/e2fsprogs-libuuid
Added tools/masssievec perl/sieve/scripts/*.pl to SHEBANG_FILES
INSTALL_TARGET=install-strip and ${STRIP_CMD} in the post-install for the perl .so
Added PORTREVISION = 1

This changes fixes all Warnings and Errors in "Running Q/A tests (stage-qa)" for the port.


There is a configure warning too for an unknow option --with-cyrus-group. I did not address this:
configure: WARNING: unrecognized options:  --with-cyrus-group

Please check the Makefile. I'm not 100% sure if my ${STRIP_CMD} option is "best practice".
Comment 1 commit-hook freebsd_committer 2020-06-01 12:58:34 UTC
A commit references this bug:

Author: ume
Date: Mon Jun  1 12:57:31 UTC 2020
New revision: 537480
URL: https://svnweb.freebsd.org/changeset/ports/537480

Log:
  - Add LIB_DEPENDS to libuuid.so:misc/e2fsprogs-libuuid explicitly
  - Add tools/masssievec perl/sieve/scripts/*.pl to SHEBANG_FILES
  - Install binaries with strip
  - Nuke deprecated --with-cyrus-group option

  PR:		246904
  Submitted by:	thomas

Changes:
  head/mail/cyrus-imapd32/Makefile
Comment 2 Hajimu UMEMOTO freebsd_committer 2020-06-01 13:01:18 UTC
Thanks, committed!