Bug 246925 - net/miniupnpd: Update to 2.1.20200510
Summary: net/miniupnpd: Update to 2.1.20200510
Status: In Progress
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords: buildisok, easy, patch, patch-ready
Depends on:
Blocks:
 
Reported: 2020-06-01 21:49 UTC by Tor Halvard Furulund
Modified: 2020-06-12 11:52 UTC (History)
2 users (show)

See Also:
ehaupt: maintainer-feedback?


Attachments
Patch against current ports. (11.51 KB, patch)
2020-06-01 21:49 UTC, Tor Halvard Furulund
squat: maintainer-approval+
Details | Diff
Revised patch (see my comment) (13.57 KB, patch)
2020-06-11 20:47 UTC, Emanuel Haupt
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tor Halvard Furulund 2020-06-01 21:49:38 UTC
Created attachment 215150 [details]
Patch against current ports.

Update to latest upstream.
Remove the extra patches as they are incorporated upstream and change from EXTRA_PATCHES to CONFIGURE_ARGS for the PORT_OPTIONS.
Comment 1 Automation User 2020-06-01 22:07:01 UTC
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/151755877
Comment 2 Emanuel Haupt freebsd_committer 2020-06-11 20:45:03 UTC
Thank you for your patch!

1. You've commented the IPF functionality:

+#if ${PORT_OPTIONS:MIPFW}
+#CONFIGURE_ARGS+= --firewall=ipfw
+#.endif

Was this intentional or can it be removed?

2. Same with AUTODETECT_FW. The option is defined but it does not seem to have a
handler.

3. Your patch indroduced a lot of unneccessary whitespaces. Try running
portlint -A (ports-mgmt/portlint) within the ports directory to catch those
errors.

4. Also, the OPTIONS handling can be simplified with OPTIONS helpers. See:
https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-options.html

5. I've created a patch to address most of the issues. Could you please apply it
and look into 1 and 2? Additionally I've run portfmt and portclippy
(ports-mgmt/portfmt) to address some indentation and formating issues.
Comment 3 Emanuel Haupt freebsd_committer 2020-06-11 20:47:12 UTC
Created attachment 215469 [details]
Revised patch (see my comment)