Bug 246980 - lang/sdcc: update to 4.0.0
Summary: lang/sdcc: update to 4.0.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Alexey Dokuchaev
Keywords: patch
Depends on:
Reported: 2020-06-04 12:51 UTC by Daniel O'Connor
Modified: 2020-07-01 07:29 UTC (History)
3 users (show)

See Also:
darius: maintainer-feedback+

Update port to 4.0.0 (2.51 KB, patch)
2020-06-04 12:51 UTC, Daniel O'Connor
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel O'Connor 2020-06-04 12:51:15 UTC
Created attachment 215226 [details]
Update port to 4.0.0

I removed the restriction on aarch64 based on testing in a VM.
I tested on amd64 and aarch64 but running the regression tests after installation (ie "cd work/sdcc-4.0.0/support/regression; gmake") although I ran out of space on my aarch64 VM part way through...
Comment 1 Fernando Apesteguía freebsd_committer 2020-06-04 13:19:42 UTC
^Triage: Please set the maintainer-approval attachment flag (to +) on patches for ports you maintain to signify approval

Attachment -> Details -> maintainer-approval [+]

Comment 2 Mikael Urankar freebsd_committer 2020-06-04 15:28:27 UTC
=> SHA256 Checksum OK for sdcc-src-4.0.0.tar.bz2.
===>  Patching for sdcc-4.0.0
===>  Applying FreeBSD patches for sdcc-4.0.0 from /usr/ports/lang/sdcc/files
1 out of 2 hunks failed--saving rejects to device/lib/Makefile.in.rej
===>  FAILED Applying FreeBSD patch-device-lib-Makefile.in
===> FAILED to apply cleanly FreeBSD patch(es)  patch-device-lib-Makefile.in
*** Error code 1
Comment 3 Mikael Urankar freebsd_committer 2020-06-04 17:41:34 UTC
(In reply to darius from comment #0)
The tests ran to completion on my aarch64 board.
Comment 4 Daniel O'Connor 2020-06-05 00:58:38 UTC
(In reply to Mikael Urankar from comment #3)
Thanks Mikael
Comment 5 Fernando Apesteguía freebsd_committer 2020-06-12 10:45:06 UTC
The patch does not apply.

Would you upload a new version, please?
Comment 6 commit-hook freebsd_committer 2020-07-01 07:25:36 UTC
A commit references this bug:

Author: danfe
Date: Wed Jul  1 07:24:55 UTC 2020
New revision: 540930
URL: https://svnweb.freebsd.org/changeset/ports/540930

  - Update `lang/sdcc' to version 4.0.0
  - Hook up regression tests to our framework

  PR:		246980
  Submitted by:	maintainer

Comment 7 Alexey Dokuchaev freebsd_committer 2020-07-01 07:29:11 UTC
(In reply to Fernando Apesteguía from comment #5)
> The patch does not apply.  Would you upload a new version, please?
No need to, it was trivial issue.  I've updated the port with ports r540930.