Bug 246981 - ports-mgmt/pkg plugins: configuration settings not provided due to missing object allocation
Summary: ports-mgmt/pkg plugins: configuration settings not provided due to missing ob...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-pkg (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-06-04 13:35 UTC by Markus Stoff
Modified: 2020-09-12 12:48 UTC (History)
3 users (show)

See Also:
linimon: maintainer-feedback? (pkg)

Attachments
Suggested fix for libpkg/plugins.c and updated examples (5.18 KB, application/gzip)
2020-06-04 13:35 UTC, Markus Stoff 		no flags Details
Suggested fix for libpkg/plugins.c (656 bytes, patch)
2020-06-04 13:36 UTC, Markus Stoff 		no flags Details | Diff
Updated examples in pkg-plugins repository (15.26 KB, patch)
2020-06-04 13:38 UTC, Markus Stoff 		no flags Details | Diff
Updated examples in pkg-plugins repository (17.55 KB, patch)
2020-06-05 08:21 UTC, Markus Stoff 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Stoff 2020-06-04 13:35:18 UTC 
Created attachment 215227 [details]
Suggested fix for libpkg/plugins.c and updated examples

Due to a missing allocation of the UCL base object the configuration is parsed but not provided to the plugin.

See 'pkg.diff' in the attached archive for a suggested fix of libpkg/plugins.c.

Also the examples in the 'pkg-plugins' repository are severely outdated. Please see the other diff on some improvements, notably of the template and the zfssnap plugins.
Comment 1 Markus Stoff 2020-06-04 13:36:47 UTC 
Created attachment 215228 [details]
Suggested fix for libpkg/plugins.c
Comment 2 Markus Stoff 2020-06-04 13:38:26 UTC 
Created attachment 215229 [details]
Updated examples in pkg-plugins repository

Diff is based on github repo at https://github.com/freebsd/pkg-plugins/
Comment 3 Mark Linimon freebsd_committer freebsd_triage 2020-06-05 07:17:25 UTC 
Fix up assignment.

fwiw Ports Infrastructure is, and only is, about the *.FreeBSD.org package building machines.
Comment 4 Markus Stoff 2020-06-05 08:21:46 UTC 
Created attachment 215243 [details]
Updated examples in pkg-plugins repository

Based on: https://github.com/freebsd/pkg-plugins/