Bug 246987 - sysutils/dvdisaster: Fix build error with gcc10
Summary: sysutils/dvdisaster: Fix build error with gcc10
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords: needs-qa, patch
Depends on:
Blocks: 246700 246957
  Show dependency treegraph
 
Reported: 2020-06-04 17:28 UTC by Bob Eager
Modified: 2020-06-12 21:34 UTC (History)
3 users (show)

See Also:


Attachments
Diffs for port files (1.84 KB, patch)
2020-06-04 17:28 UTC, Bob Eager
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bob Eager 2020-06-04 17:28:35 UTC
Created attachment 215232 [details]
Diffs for port files

Fails to build with gcc10 due to misuse of/missing extern.

Patch attached.

NEW FILE: files/patch-dvdisaster.h

Tested on 12.1-RELEASE-p5 (amd64) and on 13-CURRENT (amd64).

PR 246957 refers.
Comment 1 commit-hook freebsd_committer 2020-06-12 21:31:13 UTC
A commit references this bug:

Author: gerald
Date: Fri Jun 12 21:30:45 UTC 2020
New revision: 538632
URL: https://svnweb.freebsd.org/changeset/ports/538632

Log:
  Fix the build with GCC 10 that defaults to -fno-common via a new local
  patch files/patch-dvdisaster.h.

  PR:		246700, 246957, 246987
  Submitted by:	bob@eager.cx (maintainer)

Changes:
  head/sysutils/dvdisaster/files/patch-dvdisaster.h
Comment 2 Gerald Pfeifer freebsd_committer 2020-06-12 21:34:49 UTC
Thank you for the super quick response, Bob!

I committed your patch, just omitted two aspects:

 - The PORTREVISION bump, since we do not need to do that for build fixes.
   (Where it built before, the result should not change; if it did not, there
   is no previous package).

 - The "empty" patch for another file. (To reduce churn in the repo.)