Bug 247042 - editors/emacs: make GSETTINGS usable without DBUS
Summary: editors/emacs: make GSETTINGS usable without DBUS
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: emacs@FreeBSD.org (Nobody)
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2020-06-07 09:52 UTC by Jan Beich
Modified: 2020-06-07 17:09 UTC (History)
1 user (show)

See Also:
jrm: maintainer-feedback+


Attachments
v1 (1.31 KB, patch)
2020-06-07 09:52 UTC, Jan Beich
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer 2020-06-07 09:52:20 UTC
Created attachment 215312 [details]
v1

GSettings itself doesn't use DBus, relying on the backend. GConf (deprecated) and DConf do need DBus unlike Memory (useless) and Keyfile (bug 247039). Let's drop synthetic dependency (originally added in ports r414447).

Example:

  $ gsettings set org.gnome.desktop.interface toolbar-style text
  $ emacsclient -e '(tool-bar-get-system-style)'
  text
  $ pgrep -a dbus || echo Not running
  Not running
Comment 1 Joseph Mingrone freebsd_committer 2020-06-07 16:04:22 UTC
Hello Jan,

Unfortunately I didn't document that change very well, but it (now) seems fine.  I don't use gsettings or Gnome, so I will trust your judgement.  Do you want me to commit?
Comment 2 Joseph Mingrone freebsd_committer 2020-06-07 16:25:44 UTC
Some other points that we will leave to you.

- a PORTREVISION bump is probably not worth it, since the default package is not changing, but I can guess some people will say it's useful since some package could change.
- If you do commit, you could wait on editors/emacs-devel.  We have an update coming on the 15th.  Again, your call.

Thanks for submitting.
Comment 3 commit-hook freebsd_committer 2020-06-07 16:57:33 UTC
A commit references this bug:

Author: jbeich
Date: Sun Jun  7 16:56:36 UTC 2020
New revision: 538169
URL: https://svnweb.freebsd.org/changeset/ports/538169

Log:
  editors/emacs: divorce GSETTINGS from DBUS

  Whether GSettings uses DBus at runtime depends on the backend.

  PR:		247042
  Approved by:	jrm

Changes:
  head/editors/emacs/Makefile
  head/editors/emacs-devel/Makefile
Comment 4 Jan Beich freebsd_committer 2020-06-07 17:09:05 UTC
(In reply to Joseph Mingrone from comment #1)
> I don't use gsettings or Gnome

DBUS option is still enabled by default. Gnome folks decided long ago to not support DBus-less configuration. However, outside of desktop environments DBus is not useful/common enough.

(In reply to Joseph Mingrone from comment #2)
> some people will say it's useful since some package could change.

Only who haven't intalled devel/dbus yet. Avoiding requires effort because x11-toolkits/gtk30 also depends on dbus via at-spi2-core, colord and cups.