Bug 247159 - x11/sterm build failure on FB12.1
Summary: x11/sterm build failure on FB12.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Piotr Kubaj
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-06-11 09:06 UTC by Gian-Simon Purkert
Modified: 2020-06-11 21:14 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (pkubaj)

Attachments
build-output (5.42 KB, text/plain)
2020-06-11 09:06 UTC, Gian-Simon Purkert 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gian-Simon Purkert 2020-06-11 09:06:36 UTC 
Created attachment 215437 [details]
build-output

Does not build even with MAKE_JOBS_UNSAFE=yes, also the patch 'scroll-back' could not be applied.
Comment 1 Piotr Kubaj freebsd_committer freebsd_triage 2020-06-11 11:32:54 UTC 
Probably your config is wrong, the port builds just fine. I will look at the scrollback issue.
Comment 2 Gian-Simon Purkert 2020-06-11 11:40:35 UTC 
Yes correct, after rmconfig it build's just fine.

I tried with solarize and scrollback option and both 'damage' the config and dont build, even with a make config and disable the patches sterm would not build, but works fine after rmconfig.
Comment 3 Piotr Kubaj freebsd_committer freebsd_triage 2020-06-11 12:05:21 UTC 
I meant the st config, not the port config. The option damages the config, that's true, but unavoidable. You need to use the patched config file to create your own.
Comment 4 commit-hook freebsd_committer freebsd_triage 2020-06-11 12:05:50 UTC 
A commit references this bug:

Author: pkubaj
Date: Thu Jun 11 12:04:50 UTC 2020
New revision: 538473
URL: https://svnweb.freebsd.org/changeset/ports/538473

Log:
  x11/sterm: update scrollback and solarized patches to new versions, add open_copied_url patch

  Instead of storing the patches in ports, use PATCH_SITES and PATCHFILES.

  PR:             247159
  Reported by:    gspurki@gmail.com

Changes:
  head/x11/sterm/Makefile
  head/x11/sterm/distinfo
  head/x11/sterm/files/
Comment 5 Gian-Simon Purkert 2020-06-11 12:09:49 UTC 
I had no st config, it's a fresh system where st never run before.
Comment 6 Gian-Simon Purkert 2020-06-11 14:43:43 UTC 
Ok, now scrollback works, but with solarized i get that error:


=> solarized/st-solarized-both-0.8.3.diff is not in /usr/ports/x11/sterm/distinfo.
=> Either /usr/ports/x11/sterm/distinfo is out of date, or
=> solarized/st-solarized-both-0.8.3.diff is spelled incorrectly.
*** Error code 1

Stop.
make[1]: stopped in /usr/ports/x11/sterm
*** Error code 1

Stop.
make: stopped in /usr/ports/x11/sterm
Comment 7 Piotr Kubaj freebsd_committer freebsd_triage 2020-06-11 16:09:51 UTC 
Ah, right. I used bad patch name, fixed now.
Comment 8 commit-hook freebsd_committer freebsd_triage 2020-06-11 16:09:57 UTC 
A commit references this bug:

Author: pkubaj
Date: Thu Jun 11 16:09:35 UTC 2020
New revision: 538503
URL: https://svnweb.freebsd.org/changeset/ports/538503

Log:
  x11/sterm: use correct PATHFILES for SOLARIZED option

  PR:		247159
  Reported by:	gspurki@gmail.com

Changes:
  head/x11/sterm/Makefile
Comment 9 Gian-Simon Purkert 2020-06-11 21:14:40 UTC 
Nice everything works.

Thanks allot, and have a nice Day!