Bug 247231 - devel/bison package does not check for devel/libtextstyle dependency
Summary: devel/bison package does not check for devel/libtextstyle dependency
Status: Closed Works As Intended
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Sunpoet Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-06-13 11:24 UTC by jakub_lach
Modified: 2020-06-25 15:03 UTC (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description jakub_lach 2020-06-13 11:24:57 UTC
Each time I use bison from packages (as a build time dependency from portmaster --packages-build) bison package fails without libtextstyle, which is not pulled in.


<...>

checking for LIBNUMBERTEXT... yes
checking for uuidgen... /bin/uuidgen
checking for bison... /usr/local/bin/bison
checking the bison version... ld-elf.so.1: Shared object "libtextstyle.so.0" not found, required by "bison"
configure: error: failed (/usr/local/bin/bison  need 2.0+)
Comment 1 Niclas Zeising freebsd_committer 2020-06-14 15:50:15 UTC
Assign to maintainer.
Comment 2 Sunpoet Po-Chuan Hsieh freebsd_committer 2020-06-24 15:03:29 UTC
bison will not use libtetstyle if NLS is off.
NLS is enabled by default (via /usr/ports/Mk/bsd.options.mk).

from /usr/ports/devel/bison/Makefile:
 32 NLS_CONFIGURE_ENABLE=   nls
 33 NLS_CONFIGURE_OFF=      ac_cv_libtextstyle=no
 34 NLS_LIB_DEPENDS=        libtextstyle.so:devel/libtextstyle
 35 NLS_USES=               gettext

What bison package are you using?
Comment 3 jakub_lach 2020-06-24 20:54:16 UTC
I have in ports.conf -

OPTIONS_UNSET= NLS DOCS EXAMPLES, though bison is installed as a dependency while using 'portmaster --packages-build --delete-build-only -a' so I presume it's a default freebsd package (build dependency).
Comment 4 Sunpoet Po-Chuan Hsieh freebsd_committer 2020-06-25 07:02:33 UTC
You used a bison package which is built with NLS enabled. The failure is a correct result.

You should build a port on your own while using non-default option(s).
Comment 5 jakub_lach 2020-06-25 10:00:55 UTC
(In reply to Sunpoet Po-Chuan Hsieh from comment #4)

Yes, I've used the default package bison, which requires libtextstyle. Why it did not pull in libtextstyle then? Usually default packages pull in their dependencies.
Comment 6 Sunpoet Po-Chuan Hsieh freebsd_committer 2020-06-25 11:48:22 UTC
(In reply to jakub_lach from comment #5)

I guess that would be a problem of portmaster.
Comment 7 jakub_lach 2020-06-25 12:14:01 UTC
(In reply to Sunpoet Po-Chuan Hsieh from comment #6)

And as I've seen it only with bison packages, I've filled a PR. I didn't mean to appear confrontational, I appreciate your replies.
Comment 8 Sunpoet Po-Chuan Hsieh freebsd_committer 2020-06-25 12:28:01 UTC
(In reply to jakub_lach from comment #7)

bison and gettext-tools are the only 2 ports depending on libtextstyle (LIB_DEPENDS=libtextstyle.so:devel/libtextstyle).
Comment 9 jakub_lach 2020-06-25 15:03:09 UTC
(In reply to Sunpoet Po-Chuan Hsieh from comment #8)

It occurs with gettext package too iirc. So something makes portmaster do not recognize unsatisfied libtextstyle dependency in package.