Bug 247260 - devel/premake5: update to version alpha 15
Summary: devel/premake5: update to version alpha 15
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Mateusz Piotrowski
URL: https://github.com/premake/premake-co...
Keywords: buildisok
Depends on:
Blocks:
 
Reported: 2020-06-14 18:10 UTC by Martin Filla
Modified: 2020-06-28 09:26 UTC (History)
2 users (show)

See Also:
freebsd: maintainer-feedback+


Attachments
premake5.patch (416 bytes, patch)
2020-06-14 18:10 UTC, Martin Filla
no flags Details | Diff
premake5.diff (2.41 KB, patch)
2020-06-14 19:14 UTC, Martin Filla
no flags Details | Diff
premake5.diff (1.15 KB, patch)
2020-06-16 15:22 UTC, Martin Filla
freebsd: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Filla 2020-06-14 18:10:56 UTC
Created attachment 215554 [details]
premake5.patch

Hi,
I updated port premake5 alpha 5 to alpha 15.
M.
Comment 1 Automation User 2020-06-14 18:21:48 UTC
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/156084562
Comment 2 Martin Filla 2020-06-14 19:14:11 UTC
Created attachment 215558 [details]
premake5.diff
Comment 3 Fernando Apesteguía freebsd_committer 2020-06-15 07:01:07 UTC
^Triage: Please set the maintainer-approval attachment flag (to +) on patches for ports you maintain to signify approval

Attachment -> Details -> maintainer-approval [+]

Also, would you mind checking the patch? There seems to be a bunch of changes that actually leave the same values again:

-PORTNAME=       premake
-DISTVERSIONPREFIX=      v
-DISTVERSION=    5.0.0
-CATEGORIES=     devel
-PKGNAMESUFFIX=  5
+PORTNAME=	premake
+DISTVERSIONPREFIX=	v
+DISTVERSION=	5.0.0
+CATEGORIES=	devel
+PKGNAMESUFFIX=	5

Also, if we are updating from alpha 5 to alpha 15, shouldn't PKGNAMESUFFIX=15?
Comment 4 Martin Filla 2020-06-16 15:22:37 UTC
Created attachment 215616 [details]
premake5.diff

update patch for new version
Comment 5 commit-hook freebsd_committer 2020-06-27 13:21:18 UTC
A commit references this bug:

Author: 0mp
Date: Sat Jun 27 13:20:47 UTC 2020
New revision: 540600
URL: https://svnweb.freebsd.org/changeset/ports/540600

Log:
  Update to 5.0.0-alpha15

  While I'm here, let's clean up the port a bit:
  - Switch to MASTER_SITES from USE_GITHUB as suggested by upstream.
  - Fix a typo in ALL_TARGET.
  - Remove do-build. The ports framework does the right thing already.

  PR:		247260
  Submitted by:	Martin Filla <freebsd@sysctl.cz>

Changes:
  head/devel/premake5/Makefile
  head/devel/premake5/distinfo
Comment 6 Mateusz Piotrowski freebsd_committer 2020-06-27 13:22:48 UTC
Thanks!

I've modified the patch a bit to clean it up before committing.

BTW, some tests are failing, I didn't look into it however.
Comment 7 Martin Filla 2020-06-28 09:26:25 UTC
(In reply to Mateusz Piotrowski from comment #6)
Thank you!