Bug 247329 - www/firefox: update to 78.0 (phase: Beta, ETA: 2020-06-30)
Summary: www/firefox: update to 78.0 (phase: Beta, ETA: 2020-06-30)
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-gecko (Nobody)
URL: https://wiki.mozilla.org/Releases/Fir...
Keywords: needs-qa, patch
Depends on: 245422
Blocks:
  Show dependency treegraph
 
Reported: 2020-06-16 21:00 UTC by Jan Beich
Modified: 2020-06-29 23:16 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (gecko)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer 2020-06-16 21:00:26 UTC
See review D25301 for the patch.
Comment 1 Jan Beich freebsd_committer 2020-06-16 21:09:55 UTC
https://bugzilla.mozilla.org/show_bug.cgi?id=1619882 broke VAAPI on FreeBSD. I'm too burntout to bother investigating.
Comment 2 commit-hook freebsd_committer 2020-06-23 11:49:03 UTC
A commit references this bug:

Author: jbeich
Date: Tue Jun 23 11:48:40 UTC 2020
New revision: 539972
URL: https://svnweb.freebsd.org/changeset/ports/539972

Log:
  www/firefox: update to 78.0

  Changes:	https://www.mozilla.org/firefox/78.0/releasenotes/
  PR:		247329
  Differential Revision:	https://reviews.freebsd.org/D25301

Changes:
  head/Mk/bsd.gecko.mk
  head/www/firefox/Makefile
  head/www/firefox/distinfo
  head/www/firefox/files/patch-bug1288587
  head/www/firefox/files/patch-bug1618914
  head/www/firefox/files/patch-bug1632456
  head/www/firefox/files/patch-bug1634852
  head/www/firefox/files/patch-bug1636072
  head/www/firefox/files/patch-bug1638010
  head/www/firefox/files/patch-bug847568
Comment 3 Ashish SHUKLA freebsd_committer 2020-06-25 14:56:35 UTC
I believe this commit[1] broke Firefox on Wayland:

shm_open("/wayland.mozilla.ipc.0",O_RDWR|O_CREAT|O_EXCL,0600) = 31 (0x1f)
shm_unlink("/wayland.mozilla.ipc.0")             = 0 (0x0)
mprotect(0x91c3c818000,4096,PROT_READ|PROT_WRITE) = 0 (0x0)
posix_fallocate(0x1f,0x0,0x4)                    = 19 (0x13)
close(31)                                        = 0 (0x0)
SIGNAL 11 (SIGSEGV) code=SEGV_MAPERR trapno=12 addr=0x0
mprotect(0x91c3c818000,4096,PROT_READ|PROT_EXEC) = 0 (0x0)
sigprocmask(SIG_SETMASK,{ },0x0)                 = 0 (0x0)
unlink("/tmp/firefox/lock")                      = 0 (0x0)
close(13)                                        = 0 (0x0)


It segfaults at the startup due to posix_fallocate on a ZFS root (/wayland.mozilla.ipc.0), which seems to be the change in the referenced commit.

I'm on 12.1-RELEASE, and downgraded back to 77.0.1_1,1 for now, which works fine.

Thanks!

References:
[1] https://hg.mozilla.org/mozilla-central/rev/594ac84515dc7eeddd1d09071e4d6591524d8910
Comment 4 Jan Beich freebsd_committer 2020-06-25 15:21:03 UTC
(In reply to Ashish SHUKLA from comment #3)
> shm_open("/wayland.mozilla.ipc.0",O_RDWR|O_CREAT|O_EXCL,0600) = 31 (0x1f)

Path in shm_open() is a unique identifier, not related to filesystem. Named objects can be listed via "posixshmcontrol list" on FreeBSD and "ls /dev/shm/" on Linux.

> posix_fallocate(0x1f,0x0,0x4)                    = 19 (0x13)

Requires base r356512. I'll ignore ENODEV (19) a la bug 240884 but you'd need to confirm because -CURRENT kernel gives false positives with old jails.
Comment 5 commit-hook freebsd_committer 2020-06-25 16:05:38 UTC
A commit references this bug:

Author: jbeich
Date: Thu Jun 25 16:04:50 UTC 2020
New revision: 540400
URL: https://svnweb.freebsd.org/changeset/ports/540400

Log:
  www/firefox: unbreak Wayland on FreeBSD < 13 after r539972

  shm_open object doesn't support posix_fallocate on old kernels which
  leads to a crash.

  PR:		247329
  Reported by:	ashish

Changes:
  head/www/firefox/Makefile
  head/www/firefox/files/patch-bug1618914
Comment 6 commit-hook freebsd_committer 2020-06-25 19:45:20 UTC
A commit references this bug:

Author: jbeich
Date: Thu Jun 25 19:45:15 UTC 2020
New revision: 540404
URL: https://svnweb.freebsd.org/changeset/ports/540404

Log:
  www/firefox: switch to rc2

  Changes:	https://hg.mozilla.org/releases/mozilla-release/pushloghtml?startdate=2020-06-23&enddate=2020-06-26
  PR:		247329

Changes:
  head/www/firefox/Makefile
  head/www/firefox/distinfo
Comment 7 commit-hook freebsd_committer 2020-06-29 23:16:03 UTC
A commit references this bug:

Author: jbeich
Date: Mon Jun 29 23:15:27 UTC 2020
New revision: 540842
URL: https://svnweb.freebsd.org/changeset/ports/540842

Log:
  MFH: r534395 r539972 r540400 r540404 r540515

  www/firefox: update to 78.0

  Changes:	https://www.mozilla.org/firefox/78.0/releasenotes/
  PR:		247329
  Approved by:	ports-secteam blanket
  Differential Revision:	https://reviews.freebsd.org/D25301

Changes:
_U  branches/2020Q2/
  branches/2020Q2/Mk/bsd.gecko.mk
  branches/2020Q2/www/firefox/Makefile
  branches/2020Q2/www/firefox/distinfo
  branches/2020Q2/www/firefox/files/patch-bug1288587
  branches/2020Q2/www/firefox/files/patch-bug1612181_comment1
  branches/2020Q2/www/firefox/files/patch-bug1612184
  branches/2020Q2/www/firefox/files/patch-bug1618914
  branches/2020Q2/www/firefox/files/patch-bug1626236
  branches/2020Q2/www/firefox/files/patch-bug1632456
  branches/2020Q2/www/firefox/files/patch-bug1636072
  branches/2020Q2/www/firefox/files/patch-bug1638010
  branches/2020Q2/www/firefox/files/patch-bug847568
  branches/2020Q2/www/firefox/files/patch-freebsd11.3