Bug 247375 - multimedia/ffmpeg: fix build on powerpc, powerpc64
Summary: multimedia/ffmpeg: fix build on powerpc, powerpc64
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: powerpc Any
: --- Affects Many People
Assignee: freebsd-multimedia (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-06-18 10:40 UTC by Piotr Kubaj
Modified: 2020-06-18 13:10 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (multimedia)


Attachments
patch (3.99 KB, patch)
2020-06-18 10:40 UTC, Piotr Kubaj
jbeich: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer 2020-06-18 10:40:01 UTC
Created attachment 215730 [details]
patch

Revert https://github.com/FFmpeg/FFmpeg/commit/3a557c5d88b7b15b5954ba2743febb055549b536 due to breakage on big-endian POWER systems.

Issue reported to the mailing list but awaits moderation approval.
Comment 1 Jan Beich freebsd_committer 2020-06-18 12:32:01 UTC
Comment on attachment 215730 [details]
patch

What was the error? http://pylon.nyi.freebsd.org/data/latest-per-pkg/ffmpeg/ doesn't have a log for 4.3 yet.

Looks OK given the limited impact: no build glue, ppc-only. Reverts can often be short-circuited to rubberstamp.

(In reply to Piotr Kubaj from comment #0)
> Revert https://github.com/FFmpeg/FFmpeg/commit/3a557c5d88b7b15b5954ba2743febb055549b536
> due to breakage on big-endian POWER systems.

Put this message into patch header. Even better together with the error excerpt copy-pasta to have the full picture at hand.
Comment 2 Jan Beich freebsd_committer 2020-06-18 12:35:34 UTC
Did you try to partially revert? Instead of removing the new code put it under #ifdef __LITLE_ENDIAN__ or similar.
Comment 3 Jan Beich freebsd_committer 2020-06-18 12:41:35 UTC
(In reply to Piotr Kubaj from comment #0)
> Issue reported to the mailing list but awaits moderation approval.

Also reported in https://trac.ffmpeg.org/ticket/7124#comment:10
Comment 4 Piotr Kubaj freebsd_committer 2020-06-18 13:00:23 UTC
(In reply to Jan Beich from comment #2)
No, but we don't run on powerpc64le yet anyway. I suspect we will in the future, but this bug will have been long fixed by then.
Comment 5 Piotr Kubaj freebsd_committer 2020-06-18 13:01:21 UTC
(In reply to Piotr Kubaj from comment #4)
Also, even on powerpc64le, gcc8 and newer can apparently build correct binaries, and when we have powerpc64le port, gcc7 and older will not be in ports tree anyway.
Comment 6 commit-hook freebsd_committer 2020-06-18 13:09:17 UTC
A commit references this bug:

Author: pkubaj
Date: Thu Jun 18 13:08:58 UTC 2020
New revision: 539539
URL: https://svnweb.freebsd.org/changeset/ports/539539

Log:
  multimedia/ffmpeg: fix build on powerpc and powerpc64

  Revert 3a557c5d88b7b15b5954ba2743febb055549b536 to fix build error on POWER systems.

  PR:		247375
  Approved by:	jbeich (maintainer)

Changes:
  head/multimedia/ffmpeg/files/patch-libswscale_ppc_yuv2rgb__altivec.c