Bug 247377 - audio/ocp: fix build on powerpc64 with gcc
Summary: audio/ocp: fix build on powerpc64 with gcc
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: powerpc Any
: --- Affects Only Me
Assignee: Emanuel Haupt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-06-18 11:16 UTC by Piotr Kubaj
Modified: 2020-06-18 15:41 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (ehaupt)


Attachments
patch (1.31 KB, patch)
2020-06-18 11:16 UTC, Piotr Kubaj
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Piotr Kubaj freebsd_committer 2020-06-18 11:16:23 UTC
Created attachment 215732 [details]
patch

GCC is still used on stable/11 and stable/12. It needs sys/types.h in lzh.h, because some types are not recognized.
Comment 1 Emanuel Haupt freebsd_committer 2020-06-18 15:09:41 UTC
Thank you for the patch. Unfortunately I have no way of testing it on powerpc64. If it solves the issue, please commit.
Comment 2 commit-hook freebsd_committer 2020-06-18 15:41:50 UTC
A commit references this bug:

Author: pkubaj
Date: Thu Jun 18 15:41:33 UTC 2020
New revision: 539550
URL: https://svnweb.freebsd.org/changeset/ports/539550

Log:
  audio/ocp: fix build on powerpc64 with gcc

  GCC is still used on stable/11 and stable/12. It needs sys/types.h in lzh.h, because some types are not recognized.

  Force newer compiler due to:
  pfilesel.c:3312: error: #pragma GCC diagnostic not allowed inside functions

  Because of libstdc++ ABI changes due to forcing new compiler, audio/libadplug and devel/libbinio in order for audio/ocp to build.

  PR:		247377
  Approved by:	ehaupt (maintainer)

Changes:
  head/audio/libadplug/Makefile
  head/audio/ocp/Makefile
  head/audio/ocp/files/patch-playym_lzh_lzh.h
  head/devel/libbinio/Makefile