Bug 247438 - www/py-tuir: Correct Python <version-spec> declaration and add concurrent support
Summary: www/py-tuir: Correct Python <version-spec> declaration and add concurrent sup...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Fernando Apesteguía
URL:
Keywords: easy, needs-qa
Depends on:
Blocks:
 
Reported: 2020-06-20 12:30 UTC by Fernando Apesteguía
Modified: 2020-06-22 08:43 UTC (History)
2 users (show)

See Also:
lcook: maintainer-feedback+
fernape: merge-quarterly-


Attachments
Patch to the ports tree (723 bytes, patch)
2020-06-20 12:30 UTC, Fernando Apesteguía
no flags Details | Diff
Final patch (1.18 KB, patch)
2020-06-20 18:06 UTC, Fernando Apesteguía
lcook: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fernando Apesteguía freebsd_committer 2020-06-20 12:30:56 UTC
Created attachment 215813 [details]
Patch to the ports tree

Hi there!

There are a couple of issues with this port:

In this port we need USE_PYTHON=concurrent since it installs 'console_scripts'

For py-request, isn't the minimum required version 2.4.0? OpenBSD is using that too for this port:
https://cvsweb.openbsd.org/cgi-bin/cvsweb/ports/www/tuir/Makefile?annotate=1.2

The above changes are included in the attached patch.

Does this port work with py27? if that is the case, we should lower the python requirements. If 3.6.0+ is necessary, then we can drop the requirement for  mailcap_fix since 3.6.0 already includes an official fix.
Comment 1 Lewis Cook freebsd_committer freebsd_triage 2020-06-20 13:00:08 UTC
(In reply to Fernando Apesteguía from comment #0)

> For py-request, isn't the minimum required version 2.4.0?

Yeah. Good catch, thanks.

> Does this port work with py27? if that is the case, we should lower the python requirements. If 3.6.0+ is necessary, then we can drop the requirement for  mailcap_fix since 3.6.0 already includes an official fix.

I've checked on pypi [1] and the lowest supported version is 2.7, which would warrant the drop to py27. Rebuilt the package in Poudriere with PY_FLAVOR=py27 to see if everything works accordingly (which it does, so no issues there).

The patch looks fine; other than replacing s/python:3.6+/python:2.7+/ as discussed above. This seemed to of slipped through me, so thanks again for catching this! :)

[1] https://pypi.org/project/tuir/
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2020-06-20 15:02:55 UTC
^Triage: ports-bugs doesn't need to be in CC
Comment 3 Fernando Apesteguía freebsd_committer 2020-06-20 18:06:31 UTC
Created attachment 215822 [details]
Final patch

This one adds mailcap_fix as a conditional dependency.
Comment 4 Lewis Cook freebsd_committer freebsd_triage 2020-06-20 18:17:41 UTC
(In reply to Fernando Apesteguía from comment #3)
Good thinking with the conditional! :-)
Comment 5 Fernando Apesteguía freebsd_committer 2020-06-22 05:44:01 UTC
(In reply to Lewis Cook from comment #1)
It wasn't my catch but koobs@ ;-)
Comment 6 commit-hook freebsd_committer 2020-06-22 05:47:14 UTC
A commit references this bug:

Author: fernape
Date: Mon Jun 22 05:46:18 UTC 2020
New revision: 539796
URL: https://svnweb.freebsd.org/changeset/ports/539796

Log:
  www/py-tuir: correct python version and add concurrent support

   * The minimum Python requirement can be lowered to 2.7
   * The mailcap_fix requirement is then necessary only for python < 3.6
   * Add concurrent support

  PR:	247438
  Reported by:	koobs@

Changes:
  head/www/py-tuir/Makefile
Comment 7 Fernando Apesteguía freebsd_committer 2020-06-22 08:43:21 UTC
MFH: No (port not in quarterly branch)