Bug 247448 - ports-mgmt/poudriere: Fix jail -d -C
Summary: ports-mgmt/poudriere: Fix jail -d -C
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Bryan Drewery
URL:
Keywords: buildisok, needs-qa
Depends on:
Blocks:
 
Reported: 2020-06-20 21:50 UTC by Anton Saietskii
Modified: 2020-07-06 00:09 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (bdrewery)
koobs: merge-quarterly?

Attachments
fix -C option (350 bytes, patch)
2020-06-20 21:50 UTC, Anton Saietskii 		no flags Details | Diff
fix -C option (full patch) (1.29 KB, patch)
2020-06-20 21:54 UTC, Anton Saietskii 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anton Saietskii 2020-06-20 21:50:57 UTC 
Created attachment 215830 [details]
fix -C option

This have been implemented in https://github.com/freebsd/poudriere/pull/532, but one of the commits (https://github.com/freebsd/poudriere/pull/532/commits/33d6823387fc20480ff251adcc0bf7f3303c7ea8) was incorrect, and CLEANJAIL variable always equals 0.
Mentioned commit changed CLEAN to CLEANJAIL in lines -1021,+1016, but -1079,+1074 done incorrectly:

CLEAN=${CLEAN:-none}
CLEANJAIL=${CLEAN:-none}

Second should be:
CLEANJAIL=${CLEANJAIL:-none}
Or even better:
: "${CLEANJAIL:=none}"

I don't have a GitHub account, so attached patch that fixes ports tree itself.
Comment 1 Anton Saietskii 2020-06-20 21:54:15 UTC 
Created attachment 215831 [details]
fix -C option (full patch)
Comment 2 Automation User 2020-07-06 00:09:53 UTC 
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/163313309