Bug 247461 - [exp-run] with r362261 reverted
Summary: [exp-run] with r362261 reverted
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Ed Maste
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-06-21 16:10 UTC by Ed Maste
Modified: 2020-06-29 15:01 UTC (History)
3 users (show)

See Also:
antoine: exp-run+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Maste freebsd_committer 2020-06-21 16:10:04 UTC
r362261 applies r333944 to the base system file 5.39 update. r333944 is:

commit 4529176e694cf3104ca2e374fce48ecb36eb67be
Author: antoine <antoine@FreeBSD.org>
Date:   Sun May 20 22:07:44 2018 +0000

    Revert last change to file/magic/Magdir/elf, it misidentifies most shared
    libraries installed from ports as pie executables instead of shared libraries,
    and consequently breaks ports.

Notes:
    svn path=/head/; revision=333944

I believe the original issue is fixed upstream, and r362261 serves no purpose (and breaks file's reporting of PIE binaries, see PR 246960). Please confirm via an exp-run with r362261 reverted.
Comment 1 Antoine Brodin freebsd_committer 2020-06-29 09:36:35 UTC
Exp-run looks fine
Comment 2 commit-hook freebsd_committer 2020-06-29 13:30:52 UTC
A commit references this bug:

Author: emaste
Date: Mon Jun 29 13:30:49 UTC 2020
New revision: 362782
URL: https://svnweb.freebsd.org/changeset/base/362782

Log:
  Revert r362261, "Re-apply r333944 to unbreak ports"

  A file update in 2018 broke many ports as it misidentified shared
  libraries as PIE binaries.  r333944 reverted part of the change,
  restoring ports builds but misidentifying objects in the opposite
  direction.

  Earlier this month file 5.39 was imported, and then the change
  originally from r333944 was recommitted as r362261.  However, the
  issue was fixed upstream, so r362261 serves no purpose.

  PR:		246960, 247461 [exp-run]
  Sponsored by:	The FreeBSD Foundation

Changes:
  head/contrib/file/magic/Magdir/elf