Bug 247464 - Add support for IUTF8 tty input mode
Summary: Add support for IUTF8 tty input mode
Status: Open
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-bugs (Nobody)
URL:
Keywords: needs-qa, patch
Depends on:
Blocks:
 
Reported: 2020-06-21 20:32 UTC by Maxim Lyapin
Modified: 2020-06-22 06:25 UTC (History)
2 users (show)

See Also:

Attachments
Patches to the kernel, stty utility, and corresponding man pages (3.05 KB, patch)
2020-06-21 20:32 UTC, Maxim Lyapin 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Maxim Lyapin 2020-06-21 20:32:18 UTC 
Created attachment 215847 [details]
Patches to the kernel, stty utility, and corresponding man pages

Fixes bug #220009. Both GNU/Linux and macOS have support for the removal of UTF-8 multibyte letters when IUTF8 Input Mode is set through stty(1). Some userspace software also assumes that this flag is available on the target platform.

The patch adds basic support for such an Input Mode.
It doesn't make combining letters work, nor does it fix problems with line width when there are multibyte letters in the line; these fixes would take quite many changes. Nonetheless, it improves things a bit. :)
Comment 1 Yuri Pankov freebsd_committer freebsd_triage 2020-06-21 20:58:24 UTC 
For the record, what problems exactly are there with line width when there are multibyte characters?  Is there a separate PR?
Comment 2 Lewis Cook freebsd_committer freebsd_triage 2020-06-21 21:25:05 UTC 
^Triage: [tags] in issue Titles are deprecated
Comment 3 Maxim Lyapin 2020-06-21 22:10:23 UTC 
> For the record, what problems exactly are there with line width when there are multibyte characters?  Is there a separate PR?

Double-checked it, sorry, I had a misunderstanding of how things work. It seems, there are no problems with line widths. I shouldn't have mentioned the problem in the previous message. Really sorry for the commotion.
Comment 4 Lewis Cook freebsd_committer freebsd_triage 2020-06-22 02:03:58 UTC 
(In reply to Maxim Lyapin from comment #3)
By this accord, is it safe to assume this thread can be made closed?

^Lewis
Comment 5 Yuri Pankov freebsd_committer freebsd_triage 2020-06-22 06:22:03 UTC 
(In reply to Lewis Cook from comment #4)
No, the IUTF8 addition is useful.  I was merely asking about the other issues Maxim mentioned.
Comment 6 Lewis Cook freebsd_committer freebsd_triage 2020-06-22 06:25:18 UTC 
(In reply to Yuri Pankov from comment #5)
Gotcha, thanks. Skimmed over that part. It's safe to ignore my previous message. ;)