Bug 247520 - x11/libxkbcommon: make X11 optional
Summary: x11/libxkbcommon: make X11 optional
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-x11 (Nobody)
URL:
Keywords: patch
Depends on:
Blocks: 247091
  Show dependency treegraph
 
Reported: 2020-06-24 13:20 UTC by Jan Beich
Modified: 2020-07-11 18:25 UTC (History)
2 users (show)

See Also:
zeising: maintainer-feedback+
jbeich: merge-quarterly?


Attachments
v1 (1.81 KB, patch)
2020-06-24 13:20 UTC, Jan Beich
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer 2020-06-24 13:20:29 UTC
Created attachment 215906 [details]
v1

I'd like to make sure nothing accidentally uses X11.

  OPTIONS_UNSET += X11
  graphics_cairo_UNSET += XCB
  x11-toolkits_gtk30_UNSET += ATK_BRIDGE COLORD
Comment 1 Chris Hutchinson 2020-06-24 16:15:25 UTC
(In reply to Jan Beich from comment #0)
Apologies in advance; as I have no doubt that
what you're doing here _should_ be done. But
I can't help but ask;
doesn't the X in libxkbcommon _imply_ X11?
Or was it poorly named?

Thanks.

--Chris
Comment 2 Jan Beich freebsd_committer 2020-06-24 17:38:24 UTC
(In reply to Chris Hutchinson from comment #1)
See pkg-descr and https://wayland-book.com/seat/xkb.html. As Wayland often needs to support Xwayland (X11 apps on Wayland) and X11 session (Wayland apps on X11) it's easier if keymaps are handled by one API.
Comment 3 Chris Hutchinson 2020-06-24 17:42:50 UTC
(In reply to Jan Beich from comment #2)
Thank you very much, Jan. I guess I should have already
known that.
Thank you for taking the time! :-)

--Chris
Comment 4 Niclas Zeising freebsd_committer 2020-07-11 14:29:31 UTC
Approved.

I don't think we need to merge it to Q3.
Comment 5 commit-hook freebsd_committer 2020-07-11 17:45:56 UTC
A commit references this bug:

Author: jbeich
Date: Sat Jul 11 17:45:18 UTC 2020
New revision: 541999
URL: https://svnweb.freebsd.org/changeset/ports/541999

Log:
  x11/libxkbcommon: make X11 optional

  PR:		247520
  Approved by:	zeising

Changes:
  head/x11/libxkbcommon/Makefile
  head/x11/libxkbcommon/pkg-plist