Bug 247524 - [exp-run] add MAKE to MAKE_ENV in USES=gmake
Summary: [exp-run] add MAKE to MAKE_ENV in USES=gmake
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Port Management Team
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-06-24 16:36 UTC by Steve Wills
Modified: 2020-07-03 13:17 UTC (History)
0 users

See Also:
linimon: exp-run?


Attachments
patch (356 bytes, patch)
2020-06-24 16:36 UTC, Steve Wills
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Wills freebsd_committer 2020-06-24 16:36:10 UTC
Created attachment 215912 [details]
patch

This avoids an issue I ran into while trying to build shells/bash-completion in poudriere using qemu-user-static, but seems generally correct and needed. Please exp-run.
Comment 1 Antoine Brodin freebsd_committer 2020-07-02 17:44:53 UTC
I am wondering if it wouldn't be better to remove the MAKE= line from make.nxb.conf  (adding MAKE to MAKE_ENV does break some ports)

% ll -i nxb-bin/usr/bin/make usr/bin/make
1419 -rwxr-xr-x  2 root  wheel  4013184 Nov  5  2019 nxb-bin/usr/bin/make*
1419 -rwxr-xr-x  2 root  wheel  4013184 Nov  5  2019 usr/bin/make*

It's the same file so I don't see the need for this line
Comment 2 Steve Wills freebsd_committer 2020-07-03 13:01:40 UTC
(In reply to Antoine Brodin from comment #1)
Unfortunately, remove the MAKE= line from make.nxb.conf doesn't prevent the issue. Can you please tell me, which ports break with the change to gmake.mk?