Bug 247583 - databases/grass7: Minor problems with Makefile (and pkg-plist)
Summary: databases/grass7: Minor problems with Makefile (and pkg-plist)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Loïc Bartoletti
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-06-27 10:52 UTC by Rainer Hurling
Modified: 2020-06-29 04:39 UTC (History)
1 user (show)

See Also:
lbartoletti: maintainer-feedback+


Attachments
Makefile changes to make portlint happy (548 bytes, patch)
2020-06-27 10:52 UTC, Rainer Hurling
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rainer Hurling 2020-06-27 10:52:56 UTC
Created attachment 215978 [details]
Makefile changes to make portlint happy

Thanks for the recent update of GRASS7, much appreciated!

On my box running 13.0-CURRENT I normally build ports with having 'DEVELOPER=yes' enabled in head /etc/make.conf. For your newest port update it gives me:


!\ grass7-7.8.3: Makefile errors /!\

you cannot include bsd.port[.pre].mk twice

Defining both PORTVERSION and DISTVERSION is wrong, only set one, if necessary,
set DISTNAME

*** Error code 1

Stop.
make[1]: stopped in /usr/ports/databases/grass7


This happens because you changed bsd.port.options.mk into bsd.port.pre.mk, but not also changed bsd.port.mk into bsd.port.post.mk at the end of the file.



Some other problems are shown by 'portlint -AC':

WARN: /usr/ports/databases/grass7/pkg-plist: [15]: enumerating info files in the plist is deprecated in favor of adding info files into the Makefile using the INFO macro.
WARN: /usr/ports/databases/grass7/pkg-plist: [155]: enumerating info files in the plist is deprecated in favor of adding info files into the Makefile using the INFO macro.
WARN: /usr/ports/databases/grass7/pkg-plist: [274]: enumerating info files in the plist is deprecated in favor of adding info files into the Makefile using the INFO macro.
WARN: /usr/ports/databases/grass7/pkg-plist: [323]: enumerating info files in the plist is deprecated in favor of adding info files into the Makefile using the INFO macro.
WARN: /usr/ports/databases/grass7/pkg-plist: [3837]: enumerating info files in the plist is deprecated in favor of adding info files into the Makefile using the INFO macro.
WARN: Makefile: [135]: use a tab (not space) after a variable name
WARN: Makefile: [137]: use a tab (not space) after a variable name
WARN: Makefile: [205]: possible direct use of command "echo" found. use ${ECHO_CMD} or ${ECHO_MSG} instead.
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
0 fatal errors and 9 warnings found.


The Makefile warnings at lines 135 and 137 are solved by a change of some spaces into a tab. The warning in line 205 is harmless, because echo is a filename here, not a command.

I am not sure, if the .info files in pkg-plist should remain here or as suggested by portlint, better should be listed in the Makefile after an INFO macro. Probably it is much more clear for now to let them in pkg-plist.


For the Makefile changes a patch is attached.
Comment 1 commit-hook freebsd_committer 2020-06-29 04:30:12 UTC
A commit references this bug:

Author: lbartoletti
Date: Mon Jun 29 04:29:29 UTC 2020
New revision: 540744
URL: https://svnweb.freebsd.org/changeset/ports/540744

Log:
  databases/grass7: Unbreak ports (fix r540559)

  - fix bsd.post.mk
  - Replace spaces by tabs (pet portlint)

  PR:		247583
  Submitted by:	Rainer Hurling
  Approved by:	tcberner (mentor)
  Differential Revision:	https://reviews.freebsd.org/D25497

Changes:
  head/databases/grass7/Makefile
Comment 2 Loïc Bartoletti freebsd_committer 2020-06-29 04:39:26 UTC
Committed, Thanks!