Bug 247610 - [new port] editors/elementary-code: code editor designed for elementary OS
Summary: [new port] editors/elementary-code: code editor designed for elementary OS
Status: In Progress
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Li-Wen Hsu
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-06-28 09:21 UTC by Miguel Gocobachi
Modified: 2020-06-29 08:54 UTC (History)
2 users (show)

See Also:


Attachments
portclippy, portfmt, portlint applied (18.31 KB, patch)
2020-06-28 09:21 UTC, Miguel Gocobachi
no flags Details | Diff
dependencies updated (18.59 KB, patch)
2020-06-28 13:44 UTC, Miguel Gocobachi
no flags Details | Diff
missed one lib for accessibility (18.63 KB, patch)
2020-06-28 14:02 UTC, Miguel Gocobachi
no flags Details | Diff
fix `portlint -abct` and pkg-plist (1.37 KB, patch)
2020-06-28 17:24 UTC, Li-Wen Hsu
no flags Details | Diff
updated following suggestions (18.80 KB, patch)
2020-06-29 01:03 UTC, Miguel Gocobachi
no flags Details | Diff
updated reference of python:3.7 to python:3.7+ (18.80 KB, patch)
2020-06-29 08:15 UTC, Miguel Gocobachi
no flags Details | Diff
Olivier Duchateau suggestions (2.55 KB, patch)
2020-06-29 08:54 UTC, Miguel Gocobachi
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Miguel Gocobachi 2020-06-28 09:21:17 UTC
Created attachment 216005 [details]
portclippy, portfmt, portlint applied

new port, Code editor designed for elementary OS more information at https://github.com/elementary/code
Comment 1 Li-Wen Hsu freebsd_committer 2020-06-28 13:23:43 UTC
I think there are some dependencies missing:
https://gist.github.com/0a6017a453372f71a894ab15c21bee38
Comment 2 Miguel Gocobachi 2020-06-28 13:44:01 UTC
Created attachment 216013 [details]
dependencies updated
Comment 3 Miguel Gocobachi 2020-06-28 14:02:16 UTC
Created attachment 216014 [details]
missed one lib for accessibility

As far the github page of code now all of them are listed on LIB_DEPENDS, if the USE_GNOME includes the gtk30 automatically, yes.
Comment 4 Olivier Duchateau 2020-06-28 15:49:31 UTC
x11-fonts/droid-fonts-ttf is missing (see https://github.com/elementary/code/blob/master/data/io.elementary.code.gschema.xml#L119)

And I think value of language in spellcheck plugin must be disable, because default language (en_US) is not necessarily preferred choice for end users.

See my port [1] and especially files/pkg-message.in

[1] https://framagit.org/olivierd/freebsd-ports-pantheon/-/tree/master/editors/pantheon-code
Comment 5 Li-Wen Hsu freebsd_committer 2020-06-28 17:24:33 UTC
Created attachment 216015 [details]
fix `portlint -abct` and pkg-plist

This is the patch against attachment 216014 [details], fix `portlint -abct` and pkg-plist.
Please check, thanks!
Comment 6 Olivier Duchateau 2020-06-28 20:28:55 UTC
(In reply to Li-Wen Hsu from comment #5)

There are still GLib schemas in pkg-plist. It exists macro for that.
Comment 7 Miguel Gocobachi 2020-06-29 01:03:40 UTC
Created attachment 216021 [details]
updated following suggestions
Comment 8 Miguel Gocobachi 2020-06-29 08:15:12 UTC
Created attachment 216023 [details]
updated reference of python:3.7 to python:3.7+

following a discussion on the mailing-list, I found out I should use python:3.7+ and not python:3.7. So, I updated the reference for it.
Comment 9 Miguel Gocobachi 2020-06-29 08:16:27 UTC
(In reply to Li-Wen Hsu from comment #5)

I took your changes and are applied to the last two patches. Thanks!
Comment 10 commit-hook freebsd_committer 2020-06-29 08:22:56 UTC
A commit references this bug:

Author: lwhsu
Date: Mon Jun 29 08:22:19 UTC 2020
New revision: 540762
URL: https://svnweb.freebsd.org/changeset/ports/540762

Log:
  Add editors/elementary-code, code editor designed for elementary OS

  PR:		247610
  Submitted by:	Miguel Gocobachi <miguel@gocobachi.dev>

Changes:
  head/editors/Makefile
  head/editors/elementary-code/
  head/editors/elementary-code/Makefile
  head/editors/elementary-code/distinfo
  head/editors/elementary-code/files/
  head/editors/elementary-code/files/patch-data_io.elementary.code.desktop.in.in
  head/editors/elementary-code/files/patch-plugins_editorconfig_meson.build
  head/editors/elementary-code/pkg-descr
  head/editors/elementary-code/pkg-plist
Comment 11 Li-Wen Hsu freebsd_committer 2020-06-29 08:30:26 UTC
New port added, thanks!

Some minor tweaks:

- Python 3.7 is default so use python:build directly.
- Optional gettext needs to modify the port to not build/install related files so move to USES.
- Mode descriptive pkg-descr
Comment 12 Li-Wen Hsu freebsd_committer 2020-06-29 08:32:58 UTC
(In reply to Olivier Duchateau from comment #6)
Olivier, do you think it's possible to merge the work/fix from you?
Comment 13 Miguel Gocobachi 2020-06-29 08:54:17 UTC
Created attachment 216025 [details]
Olivier Duchateau suggestions
Comment 14 Miguel Gocobachi 2020-06-29 08:54:54 UTC
(In reply to Li-Wen Hsu from comment #12)
I am not Olivier, but I borrow his changes, thanks both of you! I missed this one before.