Bug 247722 - devel/libvirt: Fix build on aarch64
Summary: devel/libvirt: Fix build on aarch64
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: arm64 Any
: --- Affects Some People
Assignee: Roman Bogorodskiy
URL: http://thunderx1.nyi.freebsd.org/data...
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2020-07-02 17:51 UTC by Mikael Urankar
Modified: 2020-07-03 18:46 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (novel)
koobs: merge-quarterly?


Attachments
patch (1.76 KB, patch)
2020-07-02 17:51 UTC, Mikael Urankar
koobs: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mikael Urankar freebsd_committer 2020-07-02 17:51:01 UTC
Created attachment 216150 [details]
patch

/wrkdirs/usr/ports/devel/libvirt/work/libvirt-6.4.0/src/cpu/cpu_arm.c:25:11: fatal error: 'asm/hwcap.h' file not found
# include <asm/hwcap.h>
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2020-07-03 02:04:31 UTC
Comment on attachment 216150 [details]
patch

Build fixes are implicitly approved, and mergeable (if quarterly is affected):

Approved by: portmgr (blanket: build fix)
MFH: <branch> (blanket: build fix)

Feel free to self-assign and commit/merge if QA passes
Comment 2 Roman Bogorodskiy freebsd_committer 2020-07-03 09:11:43 UTC
Thanks for report!
The fix looks good to me from the first glance.
Let me know if you want me to test it, or if you've tested it already, feel free to commit.
Comment 3 commit-hook freebsd_committer 2020-07-03 18:00:15 UTC
A commit references this bug:

Author: mikael
Date: Fri Jul  3 17:59:50 UTC 2020
New revision: 541126
URL: https://svnweb.freebsd.org/changeset/ports/541126

Log:
  devel/libvirt: fix build on arm

  PR:		247722
  Approved by:	novel (maintainer)

Changes:
  head/devel/libvirt/files/patch-src_cpu_cpu__arm.c