Bug 247765 - kyua needs to flag directory cleanup failures as broken tests
Summary: kyua needs to flag directory cleanup failures as broken tests
Status: Open
Alias: None
Product: Base System
Classification: Unclassified
Component: tests (show other bugs)
Version: Unspecified
Hardware: Any Any
: Normal Affects Some People
Assignee: Enji Cooper
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-07-04 17:18 UTC by Enji Cooper
Modified: 2020-07-04 17:19 UTC (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Enji Cooper freebsd_committer 2020-07-04 17:18:14 UTC
From https://github.com/jmmv/kyua/issues/142 :

> @jmmv: If a test case causes the automatic cleanup of its work directory to fail within Kyua, then the test needs to be marked as broken. The current code from HEAD does not do that (only warnings are logged to the log file) though I have not yet validated if this is a regression in the new executor code.

In short, we should flag failures to clean up directories (example: bug 247761) as broken tests to simplify test/kyua use. Users shouldn't have to manually intervene to remove directories/files when resetting system state, unless `kyua debug` is used (this case is "by design").
Comment 1 Enji Cooper freebsd_committer 2020-07-04 17:19:55 UTC
(In reply to Enji Cooper from comment #0)

That didn't render as I would like. Let's try this again..

> @jmmv: If a test case causes the automatic cleanup of its work directory to fail
> within Kyua, then the test needs to be marked as broken. The current code from HEAD
> does not do that (only warnings are logged to the log file) though I have not yet
> validated if this is a regression in the new executor code.