Bug 247870 - emulators/qemu: does not build in presence of capstone4
Summary: emulators/qemu: does not build in presence of capstone4
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Muhammad Moinur Rahman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-07-09 11:50 UTC by Dmitry Marakasov
Modified: 2020-07-18 19:43 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (bofh)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Marakasov freebsd_committer 2020-07-09 11:50:07 UTC
qemu (as well as qemu-user-static-*) does not build when devel/capstone4 is installed.

...
===>  Configuring for qemu-4.1.1_4
...
capstone          system
...
cc -iquote /wrkdirs/usr/ports/emulators/qemu/work/qemu-4.1.1/. -iquote . -iquote /wrkdirs/usr/ports/emulators/qemu/work/qemu-4.1.1/tcg -iquote /wrkdirs/usr/ports/emulators/qemu/work/qemu-4.1.1/tcg/i386 -iquote . -iquote /wrkdirs/usr/ports/emulators/qemu/work/qemu-4.1.1 -iquote /wrkdirs/usr/ports/emulators/qemu/work/qemu-4.1.1/accel/tcg -iquote /wrkdirs/usr/ports/emulators/qemu/work/qemu-4.1.1/include -I/usr/local/include/pixman-1  -I/wrkdirs/usr/ports/emulators/qemu/work/qemu-4.1.1/dtc/libfdt  -pthread -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -I/usr/local/include  -m64 -mcx16 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common -fwrapv -std=gnu99  -I/wrkdirs/usr/ports/emulators/qemu/work/qemu-4.1.1 -I/usr/local/include -DPREFIX=\""/usr/local\"" -Wno-string-plus-int -Wno-typedef-redefinition -Wno-initializer-overrides -Wexpansion-to-defined -Wendif-labels -Wno-shift-negative-value -Wno-missing-include-dirs -Wempty-body -Wnested-externs -Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers -Wold-style-definition -Wtype-limits -fstack-protector-strong -I/usr/local/include -I/usr/local/include/p11-kit-1  -I/usr/local/include  -I/usr/local/include/libpng16  -I/usr/local/include -I/usr/local/include/libdrm -D_THREAD_SAFE -pthread  -I/usr/local/include  -iquote .. -iquote /wrkdirs/usr/ports/emulators/qemu/work/qemu-4.1.1/target/alpha -DNEED_CPU_H -iquote /wrkdirs/usr/ports/emulators/qemu/work/qemu-4.1.1/include -MMD -MP -MT disas.o -MF ./disas.d -g -O2 -pipe  -fstack-protector-strong -fno-strict-aliasing   -c -o disas.o /wrkdirs/usr/ports/emulators/qemu/work/qemu-4.1.1/disas.c
In file included from /wrkdirs/usr/ports/emulators/qemu/work/qemu-4.1.1/disas.c:9:
/wrkdirs/usr/ports/emulators/qemu/work/qemu-4.1.1/include/disas/capstone.h:6:10: error: 'capstone.h' file not found with <angled> include; use "quotes" instead
#include <capstone.h>
         ^~~~~~~~~~~~
         "capstone.h"
/wrkdirs/usr/ports/emulators/qemu/work/qemu-4.1.1/disas.c:179:17: error: unknown type name 'cs_insn'

Full build log:
https://people.freebsd.org/~amdmi3/qemu.log
Comment 1 Muhammad Moinur Rahman freebsd_committer 2020-07-09 12:11:23 UTC
I am working on updating it to 4.2.X branch. Please allow some times. I will add an OPTION for capstone4.
Comment 2 Muhammad Moinur Rahman freebsd_committer 2020-07-11 14:03:54 UTC
Just a quick question. Does the following line look reasonable?

CAPSTONE_DESC=		Disassembly framework support
Comment 3 commit-hook freebsd_committer 2020-07-18 19:43:01 UTC
A commit references this bug:

Author: bofh
Date: Sat Jul 18 19:42:02 UTC 2020
New revision: 542523
URL: https://svnweb.freebsd.org/changeset/ports/542523

Log:
  emulators/qemu: Update version 4.1.1=>4.2.1

  - Add OPTION CAPSTONE [1]

  PR:		247870 [1]
  Reported by:	amdmi3 [1]

Changes:
  head/UPDATING
  head/emulators/qemu/Makefile
  head/emulators/qemu/distinfo
  head/emulators/qemu/files/patch-Makefile
  head/emulators/qemu/files/patch-configure
  head/emulators/qemu/files/patch-include_net_net.h
  head/emulators/qemu/files/patch-include_qemu_atomic.h
  head/emulators/qemu/files/patch-qemu-doc.texi
  head/emulators/qemu/files/pcap-patch-net_net.c
  head/emulators/qemu/files/pcap-patch-qapi_net.json
  head/emulators/qemu/pkg-plist