Bug 248081 - multimedia/x264: Compatibility fix for gpac
Summary: multimedia/x264: Compatibility fix for gpac
Status: In Progress
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Thomas Zander
URL: https://code.videolan.org/videolan/x2...
Keywords:
Depends on:
Blocks:
 
Reported: 2020-07-18 20:56 UTC by Thomas Zander
Modified: 2020-07-19 12:45 UTC (History)
1 user (show)

See Also:
koobs: maintainer-feedback+
koobs: merge-quarterly?


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Zander freebsd_committer 2020-07-18 20:56:37 UTC
After r542531, x264 needs this patch due to a function signature change in gpac 0.8 and later:

https://code.videolan.org/videolan/x264/-/merge_requests/29/diffs
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2020-07-19 03:16:25 UTC
Thanks Thomas

Approved to re-assign annd commit/merge if it passes QA
Comment 2 commit-hook freebsd_committer 2020-07-19 11:42:49 UTC
A commit references this bug:

Author: riggs
Date: Sun Jul 19 11:42:46 UTC 2020
New revision: 542565
URL: https://svnweb.freebsd.org/changeset/ports/542565

Log:
  Fix build with multimedia/gpac-libgpac 1.0.0

  PR:		248081
  Submitted by:	riggs
  Approved by:	koobs (maintainer)
  MFH:		2020Q3 (hat: ports-secteam)

Changes:
  head/multimedia/x264/files/patch-configure
  head/multimedia/x264/files/patch-output_mp4.c
Comment 3 Thomas Zander freebsd_committer 2020-07-19 11:43:48 UTC
Will push this to the Q3 branch when merging the other gpac related updates.
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2020-07-19 12:45:15 UTC
<3 thank you Thomas!