Created attachment 216567 [details]
Portscout flagged this port and since it has no maintainer, here's an update to the latest version.
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/168254477
Do you want to take maintainership of this port?
Not a major issue but is there a good reason why we're not using vendor provided tarball?
It would be nice if we could get unit tests working and from what I can tell they're compiled by default.
Are patches still valid? Most other distros doesn't seem to carry such.
Regarding a tarball: the port was using the GitHub method before so I didn't change it. Also, I was under the impression that this is the preferred method outlined in the handbook. Please educate me if I am mistaken.
I don't want to take maintainership, as I am unlikely to use the software much. That's also the reason why I just bumped the version number and not looked into the patches or added new features like unit tests. I've done this for a couple of ports as well.
"If the distribution file comes from a specific commit or tag on GitHub for which there is no officially released file."
It's also smaller, not by much however.
I think we should aim in general trying to fix as much as possible especially if it's an unmaintained port unless it involves major work.
Can you please do a quick test of unit tests works and if not disable building of tests ?
Created attachment 216599 [details]
I have incorporated the changes suggested. I have never worked with cmake unit tests. Hopefully my attempt to disable them is correct. The MASTER_SITES string is now rather ugly but grepping the ports tree for prior art yielded this result.
As this application is really not all that important to me, that's as far as I'm able and willing to go.
(In reply to Marcel Bischoff from comment #6)
Your effort is much appreciated, thank you Marcel :)
Comment on attachment 216599 [details]
Approved by: portmgr (unmaintained port)
I have a slightly improved version although test fails at unicode stage.
Created attachment 216653 [details]
Patch for ffmpegthumbnailer
Remove USES= pathfix
Depend on ffmpeg library that's actually linked (cosmetic fix)
Move GH_ACCOUNT variable to make portlint happy
Use ports framework for CMake (cosmetic fix)
Add support for "make test"
Import CMake patch from OpenSUSE
Remove patches as Net-/OpenBSD doesn't carry these, neither does Alpine or Arch Linux.
CreateThumbNonAscii test fails (file not found), I don't know how to fix this.
(In reply to daniel.engberg.lists from comment #10)
Created attachment 216825 [details]
Patch for ffmpegthumbnailer v2
Remove GH_ACCOUNT variable
Change to TEST_CMAKE_BOOL as suggested by tcberner@
Set EXTRACT_CMD as suggested by tcberner@ and dbaio@
"make test" ok - FreeBSD 13.0-CURRENT r361421 (amd64)
Poudriere testport OK 12.1-RELEASE (amd64)
A commit references this bug:
Date: Sun Aug 2 08:28:29 UTC 2020
New revision: 543931
multimedia/ffmpegthumbnailer: Update to 2.2.2
- adds TEST option. For this a manual extract command was required
as the testing uses a UTF-8 encoded file name.
Submitted by: Marcel Bischoff <email@example.com>, firstname.lastname@example.org (committed version)
Reported by: Marcel Bischoff <email@example.com>
Thank you both for working on this :)