Bug 248166 - multimedia/ffmpeg: upstream fixed SVT patches - SVTVP9 fixed + patches can be applied in any order now
Summary: multimedia/ffmpeg: upstream fixed SVT patches - SVTVP9 fixed + patches can be...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: freebsd-multimedia (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-07-22 07:24 UTC by VVD
Modified: 2020-07-24 04:49 UTC (History)
0 users

See Also:
jbeich: maintainer-feedback+


Attachments
SVTVP9 fixed + patches can be applied in any order now (3.91 KB, patch)
2020-07-22 07:24 UTC, VVD
vvd: maintainer-approval?
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description VVD 2020-07-22 07:24:50 UTC
Created attachment 216651 [details]
SVTVP9 fixed + patches can be applied in any order now

Tested on 12.1 amd64.

This patch will fix this issue too: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=247873
Comment 1 commit-hook freebsd_committer 2020-07-24 04:11:00 UTC
A commit references this bug:

Author: jbeich
Date: Fri Jul 24 04:10:32 UTC 2020
New revision: 542999
URL: https://svnweb.freebsd.org/changeset/ports/542999

Log:
  multimedia/ffmpeg: revert r538687 after r541984/r542846

  SVT patches no longer need to be applied in a specific order to enable
  more than one SVT encoder.

  PR:		248166
  Submitted by:	VVD <vvd@unislabs.com>
  MFH:		2020Q3 (simplify future MFHs)

Changes:
  head/multimedia/ffmpeg/Makefile
  head/multimedia/ffmpeg/distinfo
Comment 2 Jan Beich freebsd_committer 2020-07-24 04:15:37 UTC
Thanks for testing. However, without forcing patches to makesum the options would break on ffmpeg update and without changing from _CONFIGURE_ENABLE to _CONFIGURE_ON configure script would warn about unknown --disable-libsvt* when none or some of SVT patches are not applied.

(In reply to VVD from comment #0)
> This patch will fix this issue too:
> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=247873

Was part of ports r542846.
Comment 3 commit-hook freebsd_committer 2020-07-24 04:49:08 UTC
A commit references this bug:

Author: jbeich
Date: Fri Jul 24 04:48:19 UTC 2020
New revision: 543001
URL: https://svnweb.freebsd.org/changeset/ports/543001

Log:
  MFH: r542999

  multimedia/ffmpeg: revert r538687 after r541984/r542846

  SVT patches no longer need to be applied in a specific order to enable
  more than one SVT encoder.

  PR:		248166
  Submitted by:	VVD <vvd@unislabs.com>
  Approved by:	ports-secteam (joneum)

Changes:
_U  branches/2020Q3/
  branches/2020Q3/multimedia/ffmpeg/Makefile
  branches/2020Q3/multimedia/ffmpeg/distinfo