Bug 248195 - net/rdesktop: Update to 1.9.0, take maintainership
Summary: net/rdesktop: Update to 1.9.0, take maintainership
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Alexey Dokuchaev
URL: https://github.com/rdesktop/rdesktop/...
Keywords: buildisok
Depends on:
Blocks:
 
Reported: 2020-07-23 00:47 UTC by Greg Veldman
Modified: 2020-07-27 12:48 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (gregf)


Attachments
rdesktop-1.9.0 (2.19 KB, patch)
2020-07-23 00:47 UTC, Greg Veldman
no flags Details | Diff
rdesktop-1.9.0 (2.51 KB, patch)
2020-07-23 12:03 UTC, Greg Veldman
no flags Details | Diff
poudriere build log (79.10 KB, text/plain)
2020-07-23 12:05 UTC, Greg Veldman
no flags Details
rdesktop-1.9.0 (2.61 KB, patch)
2020-07-23 15:35 UTC, Greg Veldman
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Greg Veldman 2020-07-23 00:47:04 UTC
Created attachment 216686 [details]
rdesktop-1.9.0

Update rdesktop to 1.9.0.  Patch attached.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2020-07-23 01:44:21 UTC
^Triage: 

- [tags] in issue Titles are deprecated

- If there is a changelog or release notes URL available for this version, please add it to the URL field

- Please confirm this change passes QA (portlint, poudriere at least). 

For details and instructions, see: 

https://www.freebsd.org/doc/en/books/porters-handbook/testing.html
Comment 2 Greg Veldman 2020-07-23 12:03:29 UTC
Created attachment 216697 [details]
rdesktop-1.9.0
Comment 3 Greg Veldman 2020-07-23 12:05:24 UTC
Created attachment 216698 [details]
poudriere build log

Updates based on triage.  Attached updated patch and build log.

Portlint output:

# portlint net/rdesktop
looks fine.
Comment 4 Greg Fitzgerald 2020-07-23 14:26:44 UTC
LGTM, Thank you. If you want to set yourself as maintainer feel free. I'm not really using rdesktop at this time.
Comment 5 Greg Veldman 2020-07-23 15:35:55 UTC
Created attachment 216707 [details]
rdesktop-1.9.0

(In reply to Greg Fitzgerald from comment #4)
Sure, I don't mind taking maintainership if you want, I use rdesktop all the time both personally and at work.  Attaching updated patch to do that.
Comment 6 Alexey Dokuchaev freebsd_committer 2020-07-27 05:33:01 UTC
I've noticed that new dependency on libgnutls.so:security/gnutls had appeared in the patch, could you elaborate a bit more on where does it come from?  As a long-time user of rdesktop who prefers his systems stay GnuTLS-clean, this is certainly a regression to me.
Comment 7 James French 2020-07-27 12:28:36 UTC
(In reply to Alexey Dokuchaev from comment #6)

It looks like upstream made GnuTLS a hard dependency with this commit https://github.com/rdesktop/rdesktop/commit/90fd660803282713c3e2d29207dc26255f2e3899 some three years ago. It looks like a pretty big refactor to remove OpenSSL hooks and replace them all with GnuTLS.

Unfortunately it also looks like upstream didn't make the option selectable so it's GnuTLS or nothing.
Comment 8 Greg Veldman 2020-07-27 12:48:26 UTC
James is correct.  The change he referenced was merged into the release branch in the update from 1.8.x to 1.9.

https://github.com/rdesktop/rdesktop/releases/tag/v1.9.0