Created attachment 216686 [details]
Update rdesktop to 1.9.0. Patch attached.
- [tags] in issue Titles are deprecated
- If there is a changelog or release notes URL available for this version, please add it to the URL field
- Please confirm this change passes QA (portlint, poudriere at least).
For details and instructions, see:
Created attachment 216697 [details]
Created attachment 216698 [details]
poudriere build log
Updates based on triage. Attached updated patch and build log.
# portlint net/rdesktop
LGTM, Thank you. If you want to set yourself as maintainer feel free. I'm not really using rdesktop at this time.
Created attachment 216707 [details]
(In reply to Greg Fitzgerald from comment #4)
Sure, I don't mind taking maintainership if you want, I use rdesktop all the time both personally and at work. Attaching updated patch to do that.
I've noticed that new dependency on libgnutls.so:security/gnutls had appeared in the patch, could you elaborate a bit more on where does it come from? As a long-time user of rdesktop who prefers his systems stay GnuTLS-clean, this is certainly a regression to me.
(In reply to Alexey Dokuchaev from comment #6)
It looks like upstream made GnuTLS a hard dependency with this commit https://github.com/rdesktop/rdesktop/commit/90fd660803282713c3e2d29207dc26255f2e3899 some three years ago. It looks like a pretty big refactor to remove OpenSSL hooks and replace them all with GnuTLS.
Unfortunately it also looks like upstream didn't make the option selectable so it's GnuTLS or nothing.
James is correct. The change he referenced was merged into the release branch in the update from 1.8.x to 1.9.