Created attachment 216686 [details] rdesktop-1.9.0 Update rdesktop to 1.9.0. Patch attached.
^Triage: - [tags] in issue Titles are deprecated - If there is a changelog or release notes URL available for this version, please add it to the URL field - Please confirm this change passes QA (portlint, poudriere at least). For details and instructions, see: https://www.freebsd.org/doc/en/books/porters-handbook/testing.html
Created attachment 216697 [details] rdesktop-1.9.0
Created attachment 216698 [details] poudriere build log Updates based on triage. Attached updated patch and build log. Portlint output: # portlint net/rdesktop looks fine.
LGTM, Thank you. If you want to set yourself as maintainer feel free. I'm not really using rdesktop at this time.
Created attachment 216707 [details] rdesktop-1.9.0 (In reply to Greg Fitzgerald from comment #4) Sure, I don't mind taking maintainership if you want, I use rdesktop all the time both personally and at work. Attaching updated patch to do that.
I've noticed that new dependency on libgnutls.so:security/gnutls had appeared in the patch, could you elaborate a bit more on where does it come from? As a long-time user of rdesktop who prefers his systems stay GnuTLS-clean, this is certainly a regression to me.
(In reply to Alexey Dokuchaev from comment #6) It looks like upstream made GnuTLS a hard dependency with this commit https://github.com/rdesktop/rdesktop/commit/90fd660803282713c3e2d29207dc26255f2e3899 some three years ago. It looks like a pretty big refactor to remove OpenSSL hooks and replace them all with GnuTLS. Unfortunately it also looks like upstream didn't make the option selectable so it's GnuTLS or nothing.
James is correct. The change he referenced was merged into the release branch in the update from 1.8.x to 1.9. https://github.com/rdesktop/rdesktop/releases/tag/v1.9.0
A commit references this bug: Author: danfe Date: Fri Sep 4 06:31:39 UTC 2020 New revision: 547512 URL: https://svnweb.freebsd.org/changeset/ports/547512 Log: - Update `net/rdesktop' to the latest version 1.9.0 - Unfortunately, now used GnuTLS instead of OpenSSL - Transfer maintainership to the new volunteer - Add missing USE_XORG component and sort pkg-plist PR: 248195 Changes: head/net/rdesktop/Makefile head/net/rdesktop/distinfo head/net/rdesktop/pkg-plist
Committed with minor modifications as ports r547512, thanks!