Bug 248280 - games/dMagnetic: Update to 0.25
Summary: games/dMagnetic: Update to 0.25
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias C. Berner
URL: http://www.dettus.net/dMagnetic
Keywords:
Depends on:
Blocks:
 
Reported: 2020-07-26 16:05 UTC by Thomas Dettbarn
Modified: 2020-07-27 17:42 UTC (History)
2 users (show)

See Also:


Attachments
patch for ports/games/dMagnetic/ (1.51 KB, patch)
2020-07-26 16:05 UTC, Thomas Dettbarn
dettus: maintainer-approval+
Details | Diff
new patch for ports/games/dMagnetic, this time with the correct manpath. (1.96 KB, patch)
2020-07-26 21:00 UTC, Thomas Dettbarn
dettus: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Dettbarn 2020-07-26 16:05:10 UTC
Created attachment 216782 [details]
patch for ports/games/dMagnetic/

Hello.
So, my project games/dMagnetic saw release 0.25. 

I took the liberty of updating the port for you. 
Since I am not much of a FreeBSD user, I would kindly ask you if you guys could have a look, check if it matches your standards.


Thank you!

Thomas
Comment 1 Tobias C. Berner freebsd_committer 2020-07-26 18:05:04 UTC
Moin moin 

You seem to be missing changes to the INSTALL_MAN path in your do-install target -- that still puts the man pages to "share/man" instead of "man", contradicting the plist change.


mfg Tobias
Comment 2 Thomas Dettbarn 2020-07-26 18:38:38 UTC
Oh shoot. Sorry.
So... plist is correct?
Comment 3 Thomas Dettbarn 2020-07-26 21:00:22 UTC
Created attachment 216787 [details]
new patch for ports/games/dMagnetic, this time with the correct manpath.

Please have a look at this patch.

I removed the share/ from the manpath, and I also updated the Timestamp (which my script keeps forgetting all the time...)

Hopefully, it complies a bit better with the requirements from your ports system?
Comment 4 Fernando Apesteguía freebsd_committer 2020-07-27 15:03:35 UTC
^Triage: Maintainer-feedback flag (+) not required unless requested (?) first.
Comment 5 Tobias C. Berner freebsd_committer 2020-07-27 17:41:45 UTC
Committed, thanks.
Comment 6 commit-hook freebsd_committer 2020-07-27 17:42:13 UTC
A commit references this bug:

Author: tcberner
Date: Mon Jul 27 17:41:34 UTC 2020
New revision: 543541
URL: https://svnweb.freebsd.org/changeset/ports/543541

Log:
  games/dMagnetic: update to 0.25

  PR:		248280
  Submitted by:	Thomas Dettbarn <dettus@dettus.net> (maintainer)

Changes:
  head/games/dMagnetic/Makefile
  head/games/dMagnetic/distinfo
  head/games/dMagnetic/pkg-plist