Bug 248285 - [NEW PORT] security/intel-ipsec-mb: Intel(R) Multi-Buffer Crypto for IPsec Library
Summary: [NEW PORT] security/intel-ipsec-mb: Intel(R) Multi-Buffer Crypto for IPsec Li...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Vanilla I. Shu
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-07-26 23:01 UTC by Martin Filla
Modified: 2020-09-13 12:53 UTC (History)
3 users (show)

See Also:

Attachments
intel-ipsec-mb.shar (9.01 KB, text/plain)
2020-07-26 23:01 UTC, Martin Filla 		no flags Details
intel-ipsec-mb.shar (2.70 KB, text/plain)
2020-08-01 14:47 UTC, Martin Filla 		no flags Details
updated shar (3.38 KB, application/x-shellscript)
2020-08-05 23:11 UTC, Steve Wills 		no flags Details
updated shar (3.25 KB, application/x-shellscript)
2020-08-05 23:31 UTC, Steve Wills 		no flags Details
intel-ipsec-mb.shar (3.19 KB, text/plain)
2020-08-06 09:07 UTC, Martin Filla 		no flags Details
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Filla 2020-07-26 23:01:54 UTC 
Created attachment 216789 [details]
intel-ipsec-mb.shar

Hi,
I made a port security/intel-ipsec-mb
M.
Comment 1 Martin Filla 2020-08-01 14:47:20 UTC 
Created attachment 216937 [details]
intel-ipsec-mb.shar
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2020-08-01 14:59:17 UTC 
Hi,

plist seems to be missing?
Upstream uses tags which is a bit nicer looking that commit hash
https://github.com/intel/intel-ipsec-mb/tags so you can probably drop GH_TAGNAME. 
Remove localbase:ldflags if it's not used/required?
Any reason why we're building a static library instead of a shared (perhaps add a menu option)?
Please reference upstream PRs etc which makes it a lot easier when updating the port.

Best regards,
Daniel
Comment 3 Steve Wills freebsd_committer freebsd_triage 2020-08-05 21:58:50 UTC 
(In reply to daniel.engberg.lists from comment #2)
This hash is 260 commits past the tag for 0.54, so we shouldn't call this 0.54.
Comment 4 Steve Wills freebsd_committer freebsd_triage 2020-08-05 23:11:29 UTC 
Created attachment 217044 [details]
updated shar

This look OK?
Comment 5 Steve Wills freebsd_committer freebsd_triage 2020-08-05 23:31:42 UTC 
Created attachment 217045 [details]
updated shar

Oops, missed some things. This looks better.
Comment 6 Daniel Engberg freebsd_committer freebsd_triage 2020-08-06 01:39:25 UTC 
That looks better although I'm not sold on not using release versions unless it's for a very good reason (personal opinion). Unless we have any direct users of this port I think it would be better to ask/wait for upstream to do a proper release since master branch seems to include multiple fixes for FreeBSD, also is the patch upstreamed or a commit/PR from upstream?

Given that extensive usage of special CPU instructions I think it would be nice if we could get a "make test" target so we don't compile libraries that doesn't run at all.
Comment 7 Martin Filla 2020-08-06 09:07:08 UTC 
Created attachment 217052 [details]
intel-ipsec-mb.shar

New update with tests
Comment 8 commit-hook freebsd_committer freebsd_triage 2020-09-13 12:52:37 UTC 
A commit references this bug:

Author: vanilla
Date: Sun Sep 13 12:52:19 UTC 2020
New revision: 548475
URL: https://svnweb.freebsd.org/changeset/ports/548475

Log:
  Add intel-ipsec-mb g20200801, intel(R) Multi-Buffer Crypto for IPsec
  Library.

  PR:		248285
  Submitted by:	freebsd@sysctl.cz

Changes:
  head/security/Makefile
  head/security/intel-ipsec-mb/
  head/security/intel-ipsec-mb/Makefile
  head/security/intel-ipsec-mb/distinfo
  head/security/intel-ipsec-mb/files/
  head/security/intel-ipsec-mb/files/patch-perf_ipsec__perf.c
  head/security/intel-ipsec-mb/pkg-descr
Comment 9 Vanilla I. Shu freebsd_committer freebsd_triage 2020-09-13 12:53:36 UTC 
Committed, thanks.