Created attachment 216789 [details]
I made a port security/intel-ipsec-mb
Created attachment 216937 [details]
plist seems to be missing?
Upstream uses tags which is a bit nicer looking that commit hash
https://github.com/intel/intel-ipsec-mb/tags so you can probably drop GH_TAGNAME.
Remove localbase:ldflags if it's not used/required?
Any reason why we're building a static library instead of a shared (perhaps add a menu option)?
Please reference upstream PRs etc which makes it a lot easier when updating the port.
(In reply to daniel.engberg.lists from comment #2)
This hash is 260 commits past the tag for 0.54, so we shouldn't call this 0.54.
Created attachment 217044 [details]
This look OK?
Created attachment 217045 [details]
Oops, missed some things. This looks better.
That looks better although I'm not sold on not using release versions unless it's for a very good reason (personal opinion). Unless we have any direct users of this port I think it would be better to ask/wait for upstream to do a proper release since master branch seems to include multiple fixes for FreeBSD, also is the patch upstreamed or a commit/PR from upstream?
Given that extensive usage of special CPU instructions I think it would be nice if we could get a "make test" target so we don't compile libraries that doesn't run at all.
Created attachment 217052 [details]
New update with tests
A commit references this bug:
Date: Sun Sep 13 12:52:19 UTC 2020
New revision: 548475
Add intel-ipsec-mb g20200801, intel(R) Multi-Buffer Crypto for IPsec
Submitted by: firstname.lastname@example.org