Bug 248323 - databases/sqlite3: Line editing library options broken
Summary: databases/sqlite3: Line editing library options broken
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Guido Falsi
URL:
Keywords:
Depends on:
Blocks: 239228
  Show dependency treegraph
 
Reported: 2020-07-28 12:50 UTC by Guido Falsi
Modified: 2020-08-01 19:15 UTC (History)
2 users (show)

See Also:
madpilot: maintainer-feedback? (pavelivolkov)


Attachments
Fix for sqlite3 readline/libedit options (1.51 KB, patch)
2020-07-28 12:50 UTC, Guido Falsi
pavelivolkov: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Guido Falsi freebsd_committer 2020-07-28 12:50:35 UTC
Created attachment 216835 [details]
Fix for sqlite3 readline/libedit options

Hi,

I just noticed that after r542047 has been committed the options to have a line editing library linked with sqlite3 are all broken.

At present the port defines option names READLINES, READLINEP and EDITLINE, but then uses option helpers for option name READLINE and LIBEDIT. This makes it impossible to have the port link with any of these libraries.

This has also been noticed by sunpoet in a message to svn-ports-all.

r542047 also removed all these options descriptions, which I'm putting back with slightly changed text.

While here I also made the other descriptions all start with upper case letters, as is usually done.

I'm attaching a patch partly reverting r542047, putting back READLINES and READLINEP option helpers, and also fixing the EDITLINE/LIBEDIT incongruity. I'm leaving the change of default to libedit and moving from OPTIONS_GROUP to OPTIONS_RADIO.

BTW the change to OPTIONS_RADIO also fixes bug 239228, which I'm referencing from this bug.

I'd like to commit this soon to fix the immediate issue and add back the option to have a line editing library linked in sqlite3.

If further changes are planned to the port those can be discussed later.
Comment 1 Pavel Volkov 2020-08-01 11:27:35 UTC
Comment on attachment 216835 [details]
Fix for sqlite3 readline/libedit options

Hello. I'm approved this path. Thank you.
Comment 2 commit-hook freebsd_committer 2020-08-01 19:14:51 UTC
A commit references this bug:

Author: madpilot
Date: Sat Aug  1 19:14:10 UTC 2020
New revision: 543921
URL: https://svnweb.freebsd.org/changeset/ports/543921

Log:
  - Add back REALINEP and READLINES options and make them and LIBEDIT
    option work after r542047 [1]
  - Also add back options descriptions [1]
  - While here make STAT3 and STAT4 options descriptions start with
    uppercase letter [1]
  - Since in r542047 OPTIONS_GROUP_RL was changed to OPTIONS_RADIO_RL
    also bug 239228 can be closed [2]

  PR:		248323 [1], 239228 [2]
  Submitted by:	myself [1], Dennis Clarke <dclarke@blastwave.org> [2]
  Approved by:	maintainer [1]

Changes:
  head/databases/sqlite3/Makefile
Comment 3 Guido Falsi freebsd_committer 2020-08-01 19:15:08 UTC
Patch committed. Thanks!