Bug 248397 - x11-fonts/terminus-font: Added large font sizes
Summary: x11-fonts/terminus-font: Added large font sizes
Status: In Progress
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Niclas Zeising
Keywords: patch
Depends on:
Reported: 2020-07-31 22:17 UTC by Dmitry Wagin
Modified: 2020-08-13 16:10 UTC (History)
0 users

See Also:
zeising: maintainer-feedback+

terminus-font.diff (9.22 KB, patch)
2020-07-31 22:17 UTC, Dmitry Wagin
no flags Details | Diff
terminus-font.diff (14.62 KB, patch)
2020-07-31 22:19 UTC, Dmitry Wagin
no flags Details | Diff
terminus-font.diff (14.56 KB, patch)
2020-08-01 15:13 UTC, Dmitry Wagin
zeising: maintainer-approval-
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Wagin 2020-07-31 22:17:46 UTC
Created attachment 216920 [details]

Added large font sizes
Comment 1 Dmitry Wagin 2020-07-31 22:19:06 UTC
Created attachment 216921 [details]
Comment 2 Dmitry Wagin 2020-08-01 15:13:06 UTC
Created attachment 216938 [details]

fixed typo
Comment 3 Niclas Zeising freebsd_committer 2020-08-13 16:10:18 UTC
Comment on attachment 216938 [details]

I do not like this change.  Mechanically blowing up the font sizes feels unnecessary, and a burden since it means we have to carry local patches.  If this is something you want, it is better to work with upstream to make it happen (and thusly benefit everyone who uses terminus-font), and let it trickle down to FreeBSD as an update.

Secondly, the makefile changes is at least three different changes in one.  For some reason you are reworking the options, with no mention of it in the PR, and strictly unneeded since all options are in the same group anyway, and can be selected independently of another.

You are also pessimizing the build output by removing the reimplace command from the output, without mentioning it in the PR.