Bug 248418 - multimedia/gpac-libgpac: Fails to build: x11_out.c:978:109: error: no member named 'glx_context' in 'XWindow'
Summary: multimedia/gpac-libgpac: Fails to build: x11_out.c:978:109: error: no member ...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Some People
Assignee: freebsd-multimedia (Nobody)
URL:
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2020-08-01 20:56 UTC by rkoberman
Modified: 2020-08-03 17:53 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (multimedia)
koobs: merge-quarterly?


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description rkoberman 2020-08-01 20:56:22 UTC
Unable to compile the port on 12-Stable r362181 amd64. All ports are up-to-date excluding mate DE. Error in compiling x11_out.c:
  CC ../modules/x11_out/x11_out.c
../modules/x11_out/x11_out.c:978:11: warning: implicit declaration of function
      'glXMakeCurrent' is invalid in C99 [-Wimplicit-function-declaration]
                        if ( ! glXMakeCurrent(xWindow->display, xWindow-...
                               ^
../modules/x11_out/x11_out.c:978:109: error: no member named 'glx_context' in
      'XWindow'
  ...xWindow->fullscreen ? xWindow->full_wnd : xWindow->wnd, xWindow->glx_con...
                                                             ~~~~~~~  ^
1 warning and 1 error generated.
gmake[3]: *** [../config.mak:147: ../modules/x11_out/x11_out.o] Error 1
Comment 1 Paul Boehmer 2020-08-03 12:22:16 UTC
Not a fix, but enabling the OpenGL option allows this port to build.
Comment 2 commit-hook freebsd_committer 2020-08-03 17:33:45 UTC
A commit references this bug:

Author: jkim
Date: Mon Aug  3 17:33:40 UTC 2020
New revision: 544089
URL: https://svnweb.freebsd.org/changeset/ports/544089

Log:
  Add an upstream patch to fix build without OpenGL.

  https://github.com/gpac/gpac/commit/d5eedf0d5c2261e2dd228ceab2eadffdaaec1d0c

  PR:		248418

Changes:
  head/multimedia/gpac-libgpac/files/patch-modules_x11__out_x11__out.c
Comment 3 Jung-uk Kim freebsd_committer 2020-08-03 17:34:40 UTC
It should be fixed with r544089.  Thanks!
Comment 4 commit-hook freebsd_committer 2020-08-03 17:53:52 UTC
A commit references this bug:

Author: jkim
Date: Mon Aug  3 17:53:18 UTC 2020
New revision: 544093
URL: https://svnweb.freebsd.org/changeset/ports/544093

Log:
  MFH:	r544089

  Add an upstream patch to fix build without OpenGL.

  https://github.com/gpac/gpac/commit/d5eedf0d5c2261e2dd228ceab2eadffdaaec1d0c

  PR:		248418
  Approved by:	ports-secteam (blanket, build fix)

Changes:
_U  branches/2020Q3/
  branches/2020Q3/multimedia/gpac-libgpac/files/patch-modules_x11__out_x11__out.c