Bug 248433 - net/vinagre: move mandatory dependency on net/avahi-app to option AVAHI
Summary: net/vinagre: move mandatory dependency on net/avahi-app to option AVAHI
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: freebsd-gnome (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-08-02 15:02 UTC by VVD
Modified: 2020-08-02 15:26 UTC (History)
2 users (show)

See Also:
tcberner: maintainer-feedback+


Attachments
move mandatory dependency on net/avahi-app to option AVAHI (999 bytes, patch)
2020-08-02 15:02 UTC, VVD
no flags Details | Diff
move mandatory dependency on net/avahi-app to option AVAHI (798 bytes, patch)
2020-08-02 15:05 UTC, VVD
vvd: maintainer-approval?
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description VVD 2020-08-02 15:02:00 UTC
Created attachment 216959 [details]
move mandatory dependency on net/avahi-app to option AVAHI

vinagre doesn't require libavahi-common.so:net/avahi-app if option AVAHI is off.
Using this patch for serveral years without any issues.

Just tested.
- If net/avahi-app and option AVAHI is off - vinagre binary doesn't require it:
$ ldd /usr/local/bin/vinagre | grep avahi
$ readelf -d /usr/local/bin/vinagre | grep avahi
- If option AVAHI is on - vinagre binary linked with:
$ readelf -d /usr/local/bin/vinagre | grep avahi
 0x0000000000000001 NEEDED               Shared library: [libavahi-ui-gtk3.so.0]
 0x0000000000000001 NEEDED               Shared library: [libavahi-common.so.3]
 0x0000000000000001 NEEDED               Shared library: [libavahi-client.so.3]
 0x0000000000000001 NEEDED               Shared library: [libavahi-glib.so.1]
 0x0000000000000001 NEEDED               Shared library: [libavahi-gobject.so.0]

Do I need to add all these libs to the dependency list?
libavahi-common.so.3, libavahi-client.so.3, libavahi-glib.so.1 and  libavahi-gobject.so.0 provided by net/avahi-app.
Comment 1 VVD 2020-08-02 15:05:49 UTC
Created attachment 216960 [details]
move mandatory dependency on net/avahi-app to option AVAHI
Comment 2 Tobias C. Berner freebsd_committer 2020-08-02 15:26:27 UTC
Moin moin, 

Thanks.
Committed with the additional build dependency on lang/vala.

mfg Tobias
Comment 3 Tobias C. Berner freebsd_committer 2020-08-02 15:26:31 UTC
Moin moin, 

Thanks.
Committed with the additional build dependency on lang/vala.

mfg Tobias
Comment 4 commit-hook freebsd_committer 2020-08-02 15:26:31 UTC
A commit references this bug:

Author: tcberner
Date: Sun Aug  2 15:25:38 UTC 2020
New revision: 543970
URL: https://svnweb.freebsd.org/changeset/ports/543970

Log:
  net/vinagre: move dependency on avahi-app into AVAHI option

  - add missing build time dependency on valac

  PR:		248433
  Submitted by:	VVD <vvd@unislabs.com>

Changes:
  head/net/vinagre/Makefile