Bug 248438 - www/onionshare: Replace security/py-pycrypto dependency with security/py-pycryptodome
Summary: www/onionshare: Replace security/py-pycrypto dependency with security/py-pycr...
Status: In Progress
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Vinícius Zavam
URL:
Keywords:
Depends on: 248712
Blocks:
  Show dependency treegraph
 
Reported: 2020-08-02 21:11 UTC by John W. O'Brien
Modified: 2020-09-08 06:51 UTC (History)
3 users (show)

See Also:
john: maintainer-feedback+
koobs: merge-quarterly?


Attachments
www/onionshare: Replace security/py-pycrypto dependency with security/py-pycryptodome (931 bytes, patch)
2020-08-02 21:11 UTC, John W. O'Brien
john: maintainer-approval? (egypcio)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John W. O'Brien 2020-08-02 21:11:27 UTC
Created attachment 216969 [details]
www/onionshare: Replace security/py-pycrypto dependency with security/py-pycryptodome

Changelog
=========

*   Satisfy dependency on Crypto package with security/py-pycryptodome

QA
==

portlint: OK



Notes
=====

PyCrypto has not been maintained upstream since 2014.

PyCryptodome, which aims to be a drop-in replacement for PyCrypto, is actively maintained (latest release 2020-06-23).

www/onionshare only uses the Crypto.PublicKey.RSA.importKey function (in onionshare.onion.Onion.is_v2_key), which is still supported by PyCryptodome.
Comment 1 John W. O'Brien 2020-08-02 22:06:07 UTC
Port is not building with patch. Stand by for revision.
Comment 2 John W. O'Brien 2020-08-17 23:27:03 UTC
Comment on attachment 216969 [details]
www/onionshare: Replace security/py-pycrypto dependency with security/py-pycryptodome

Un-obsoleting. The reason this was not building was because of the security/py-stem dependency, which still depends on security/py-pycrypto.

QA (add'l)
==========

poudriere: OK -- testport on 12.1R amd64 w/py37 (default)
Comment 3 John W. O'Brien 2020-08-17 23:28:04 UTC
Adding affirmative feedback in my capacity as security/py-pycryptodome maintainer.
Comment 4 Vinícius Zavam freebsd_committer 2020-09-08 06:51:09 UTC
thanks for reporting and sharing a patch; appreciated.
we are gonna wait til Bug #248712 gets done before committing anything

kr,