Bug 248459 - Mk/Uses/readline.mk: Remove unnecessary 'port' argument
Summary: Mk/Uses/readline.mk: Remove unnecessary 'port' argument
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Port Management Team
URL:
Keywords:
Depends on: 248446
Blocks:
  Show dependency treegraph
 
Reported: 2020-08-03 22:30 UTC by Yasuhiro KIMURA
Modified: 2020-09-21 16:32 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (portmgr)
antoine: exp-run+


Attachments
Patch file (17.25 KB, patch)
2020-08-03 22:30 UTC, Yasuhiro KIMURA
no flags Details | Diff
Updated patch file (19.34 KB, patch)
2020-08-30 19:26 UTC, Yasuhiro KIMURA
no flags Details | Diff
Updated patch file (19.80 KB, patch)
2020-09-05 01:44 UTC, Yasuhiro KIMURA
no flags Details | Diff
Updated patch file (19.81 KB, patch)
2020-09-13 22:03 UTC, Yasuhiro KIMURA
no flags Details | Diff
Updated patch file (18.89 KB, patch)
2020-09-21 16:32 UTC, Yasuhiro KIMURA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yasuhiro KIMURA 2020-08-03 22:30:50 UTC
Created attachment 216997 [details]
Patch file

Currently no supported FreeBSD version has libreadline.so in base system. Then if 'Uses=readline' is used devel/readline is always added to dependency whether or not 'port' argument is specified. So remove unnecessary 'port' argument now.
Comment 1 VVD 2020-08-04 08:29:34 UTC
databases/sqlite3/Makefile need more work: remove option READLINES and rename option READLINEP to READLINE.
Comment 2 Yasuhiro KIMURA 2020-08-04 09:27:06 UTC
(In reply to VVD from comment #1)

It was submitted as bug #248446.
Comment 3 Sunpoet Po-Chuan Hsieh freebsd_committer 2020-08-19 16:49:52 UTC
Update patch [1]:
- Remove databases/sqlite3 after r545157
- Add missing lang/io/Makefile.addons and math/units/Makefile

[1] https://people.FreeBSD.org/~sunpoet/patch/USES-readline.txt

Pass this PR to the maintainer (portmgr@).
Comment 4 Antoine Brodin freebsd_committer 2020-08-20 09:22:18 UTC
The patch seems wrong,  all ports fail with error:

Incorrect 'USES+=readline:' readline takes no arguments
Comment 5 Yasuhiro KIMURA 2020-08-30 19:26:15 UTC
Created attachment 217658 [details]
Updated patch file

* Add missing audio/ardour6/Makefile.
* Simplify options related to readline in devel/gdb/Makefile.

I tried test build of following modified ports with poudriere and 12.1-RELEASE amd64 jail.

audio/ardour5
audio/ardour6
audio/ecasound
audio/libsmf
audio/yoshimi
biology/mrbayes
devel/gdb
devel/grv
devel/opendht
devel/tclreadline
devel/tig
games/wesnoth
lang/io
lang/mdk
lang/newlisp
lang/python27
lang/python35
lang/python36
lang/python37
lang/python38
lang/ruby25
lang/ruby26
lang/ruby27
lang/sdcc
math/R
math/asymptote
math/cvc4
math/eukleides
math/libqalculate
math/units
print/fontforge
security/krb5-116
security/krb5-117
security/krb5-118
security/krb5-devel
sysutils/bareos-server
sysutils/bareos16-server
sysutils/bareos17-server
sysutils/bareos18-server
sysutils/slurm-wlm

And all of them but sysutils/bareos-server are built successfully.
Build of sysutils/bareos-server also fails without this patch.
Comment 7 Yasuhiro KIMURA 2020-09-05 01:44:31 UTC
Created attachment 217759 [details]
Updated patch file

Fix build of lang/scm.
Comment 8 Antoine Brodin freebsd_committer 2020-09-09 06:29:49 UTC
Exp-run looks fine
Comment 9 Yasuhiro KIMURA 2020-09-13 22:03:11 UTC
Created attachment 217938 [details]
Updated patch file

Update patch to make it fit to latest ports tree.
Comment 10 Yasuhiro KIMURA 2020-09-21 16:32:51 UTC
Created attachment 218148 [details]
Updated patch file

Update patch to chase removal of audio/ardour5 and lang/python35.