Bug 248464 - [patch] Fix broken build for www/nginx when NJS or IP2PROXY are enabled
Summary: [patch] Fix broken build for www/nginx when NJS or IP2PROXY are enabled
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jochen Neumeister
URL:
Keywords: buildisok
Depends on:
Blocks:
 
Reported: 2020-08-04 11:03 UTC by Ryan Steinmetz
Modified: 2020-08-22 21:09 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (joneum)

Attachments
Build fixes patch (2.16 KB, text/plain)
2020-08-04 11:03 UTC, Ryan Steinmetz 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Steinmetz freebsd_committer freebsd_triage 2020-08-04 11:03:49 UTC 
Created attachment 217001 [details]
Build fixes patch

- Fix broken build after NJS update (missing USES+=libedit)
- Fix broken build when IP2PROXY is enabled (bad comparison)
- Bump PORTREVISION
Comment 1 Ryan Steinmetz freebsd_committer freebsd_triage 2020-08-04 11:05:31 UTC 
====> Running Q/A tests (stage-qa)
Error: Bad linking on [libedit.so.7] for /usr/local/sbin/njs please add USES=libedit
Comment 2 Automation User 2020-08-19 00:12:51 UTC 
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/179438683
Comment 3 commit-hook freebsd_committer freebsd_triage 2020-08-21 11:35:44 UTC 
A commit references this bug:

Author: joneum
Date: Fri Aug 21 11:35:05 UTC 2020
New revision: 545592
URL: https://svnweb.freebsd.org/changeset/ports/545592

Log:
  - Fix broken build after NJS update (missing USES+=libedit)
  - Fix broken build when IP2PROXY is enabled (bad comparison)

  PR:		248464
  Reported by:	zi
  Sponsored by:	Netzkommune GmbH

Changes:
  head/www/nginx/Makefile
  head/www/nginx/Makefile.extmod
  head/www/nginx/files/extra-patch-ip2proxy
Comment 4 Sergey A. Osokin freebsd_committer freebsd_triage 2020-08-22 19:36:15 UTC 
Hi there,

the change related to libedit looks unclear to me because:

- it's possible to build njs module with system /lib/libedit.so.7 on FreeBSD 12.1;
- according to the FreeBSD Porters Handbook, we should specify USES=libedit if 
  a port uses the devel/libedit only.

Could you give me some lights on this.

Thank you.
Comment 5 Ryan Steinmetz freebsd_committer freebsd_triage 2020-08-22 20:59:09 UTC 
It links against it, poudriere picks this up.

Remove the USES line and try to build it in poudriere if you would like additional verification.
Comment 6 Sergey A. Osokin freebsd_committer freebsd_triage 2020-08-22 21:03:18 UTC 
Hi Ryan,

thanks for the update.

Is there poudriere logs available to view?

Thanks.
Comment 7 Ryan Steinmetz freebsd_committer freebsd_triage 2020-08-22 21:09:11 UTC 
Sorry, did not save them.