Bug 248559 - net-im/gajim: update to 1.2.2
Summary: net-im/gajim: update to 1.2.2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Ruslan Makhmatkhanov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-08-09 18:25 UTC by yzrh
Modified: 2021-03-18 13:38 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (rm)


Attachments
Patch against r532905 (4.19 KB, patch)
2020-08-09 18:27 UTC, yzrh
no flags Details | Diff
Patch against r532905 (fix PY_FLAVOR) (4.24 KB, patch)
2020-08-10 18:56 UTC, yzrh
no flags Details | Diff
Patch against r532905 (4.24 KB, patch)
2020-08-20 15:08 UTC, yzrh
no flags Details | Diff
testport log (gzipped) (26.17 KB, application/gzip)
2020-08-20 15:08 UTC, yzrh
no flags Details
Patch against r532905 (4.22 KB, patch)
2020-08-20 15:25 UTC, yzrh
no flags Details | Diff
testport log (gzipped) (26.27 KB, application/gzip)
2020-08-20 15:26 UTC, yzrh
no flags Details
nbxmpp-1.0.2 (940 bytes, patch)
2020-08-26 21:19 UTC, yzrh
no flags Details | Diff
pygobject3-common-3.36.1 (5.91 KB, patch)
2020-08-26 21:20 UTC, yzrh
no flags Details | Diff
py-gobject3 (update pkg-plist) (3.82 KB, patch)
2020-08-26 21:21 UTC, yzrh
no flags Details | Diff
testport log of py37-gobject3-3.36.1 (93.37 KB, text/plain)
2020-08-26 21:22 UTC, yzrh
no flags Details
testport log of py37-nbxmpp-1.0.2 (41.30 KB, text/plain)
2020-08-26 21:23 UTC, yzrh
no flags Details
testport log of pygobject3-common-3.36.1 (27.11 KB, text/plain)
2020-08-26 21:23 UTC, yzrh
no flags Details
gajim-1.3.1.diff (2.50 KB, patch)
2021-03-10 12:16 UTC, Goran Mekić
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description yzrh 2020-08-09 18:25:12 UTC
Release notes: https://gajim.org/post/2020-07-08-gajim-1.2.1-released/

As mentioned in release notes,  bundled plug-ins will be enabled
automatically.  Shell we at least include these two common ones:

https://dev.gajim.org/gajim/gajim-plugins/-/wikis/OmemoGajimPlugin
https://dev.gajim.org/gajim/gajim-plugins/-/wikis/UrlImagePreviewPlugin

Or just package all of them?
Comment 1 yzrh 2020-08-09 18:27:22 UTC
Created attachment 217117 [details]
Patch against r532905

It builds.  Poudriere does not complain.
Please test it more.
Comment 2 Ruslan Makhmatkhanov freebsd_committer freebsd_triage 2020-08-10 08:40:20 UTC
Hello, this is a major port Makefile rewrite. Would you clarify more why it is needed? For example, why you dropped PY_FLAVOR part, why gajim needs libsoup in LIB_DEPENDS etc?
Comment 3 yzrh 2020-08-10 18:56:21 UTC
Created attachment 217135 [details]
Patch against r532905 (fix PY_FLAVOR)

Sorry for delay.  I totally forgot about PY_FLAVOR,
it is fixed.

libsoup is listed in runtime requirement:

https://dev.gajim.org/gajim/gajim/-/commit/48cf636600d41a880fc9285d3a2b225936d998bd
Comment 4 yzrh 2020-08-20 15:08:03 UTC
Created attachment 217381 [details]
Patch against r532905
Comment 5 yzrh 2020-08-20 15:08:46 UTC
Created attachment 217382 [details]
testport log (gzipped)

portlint -C
WARN: Makefile: Consider adding support for a NLS knob to conditionally disable gettext support.
0 fatal errors and 1 warning found.
Comment 6 yzrh 2020-08-20 15:25:56 UTC
Created attachment 217383 [details]
Patch against r532905

Remove unused USES=xorg
Comment 7 yzrh 2020-08-20 15:26:30 UTC
Created attachment 217384 [details]
testport log (gzipped)

portlint -C
WARN: Makefile: Consider adding support for a NLS knob to conditionally disable gettext support.
0 fatal errors and 1 warning found.
Comment 8 Matthieu Volat 2020-08-25 16:43:26 UTC
This patch works as far as packaging is concerned, but running gajim requires first a py-nbxmpp update to at least 1.0.2:

% gajim
Traceback (most recent call last):
[...]
  File "/usr/local/lib/python3.7/site-packages/pkg_resources/__init__.py", line 786, in resolve
    raise DistributionNotFound(req, requirers)
pkg_resources.DistributionNotFound: The 'nbxmpp>=1.0.2' distribution was not found and is required by gajim


I checked the 1.2.0 branch, it also required some newer gnome/glib stuff that was is currently in ports, has something changed?
Comment 9 yzrh 2020-08-26 12:26:05 UTC
https://dev.gajim.org/gajim/python-nbxmpp/-/tags

It was tagged recently.  I guess we need to at least
update net-im/py-nbxmpp.
Comment 10 yzrh 2020-08-26 19:33:39 UTC
Okay.  I think glib is a tough one.  I tried to compile
2.64.5,  it fails with:

Checking for function "ngettext": NO
Library intl found: NO
Comment 11 yzrh 2020-08-26 21:19:08 UTC
Created attachment 217555 [details]
nbxmpp-1.0.2
Comment 12 yzrh 2020-08-26 21:20:50 UTC
Created attachment 217556 [details]
pygobject3-common-3.36.1
Comment 13 yzrh 2020-08-26 21:21:42 UTC
Created attachment 217557 [details]
py-gobject3 (update pkg-plist)
Comment 14 yzrh 2020-08-26 21:22:41 UTC
Created attachment 217558 [details]
testport log of py37-gobject3-3.36.1
Comment 15 yzrh 2020-08-26 21:23:18 UTC
Created attachment 217559 [details]
testport log of py37-nbxmpp-1.0.2
Comment 16 yzrh 2020-08-26 21:23:38 UTC
Created attachment 217560 [details]
testport log of pygobject3-common-3.36.1
Comment 17 yzrh 2020-08-26 21:29:43 UTC
devel/glib20 >=2.60.0 is next.  Let me find out
what needs to be done tomorrow.
Comment 18 Ruslan Makhmatkhanov freebsd_committer freebsd_triage 2021-02-24 08:33:04 UTC
pygobject is now at 3.38 and glib at 2.66 in ports, so we are ready to update gajim.
Comment 19 Ruslan Makhmatkhanov freebsd_committer freebsd_triage 2021-02-24 08:35:41 UTC
and gajim 1.3.0 is now available
Comment 20 Goran Mekić 2021-03-10 12:16:22 UTC
Created attachment 223149 [details]
gajim-1.3.1.diff

My poudriere testport is still runing, but I do use this version on my desktop without any obvious problems.
Comment 21 Ruslan Makhmatkhanov freebsd_committer freebsd_triage 2021-03-10 12:55:56 UTC
(In reply to Goran Mekić from comment #20)

yeah, please see my response in https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=254183#c1
Comment 22 commit-hook freebsd_committer freebsd_triage 2021-03-11 12:37:14 UTC
A commit references this bug:

Author: rm
Date: Thu Mar 11 12:36:36 UTC 2021
New revision: 568087
URL: https://svnweb.freebsd.org/changeset/ports/568087

Log:
  net-im/gajim: update to 1.3.1

  https://gajim.org/post/2021-02-08-gajim-1.3.0-released/
  https://gajim.org/post/2021-03-01-gajim-1.3.1-released/

  Thank you Goran Meki? for help with testing!

  PR:		248559
  Submitted by:	yzrh@noema.org (based on)
  Tested by:	Goran Meki? <meka@tilda.center>

Changes:
  head/net-im/gajim/Makefile
  head/net-im/gajim/distinfo
Comment 23 Ruslan Makhmatkhanov freebsd_committer freebsd_triage 2021-03-11 12:38:34 UTC
gajim update finally landed, thank you!
Comment 24 Alastair Hogge 2021-03-18 01:40:44 UTC
Thanks for updating Gajim, however, all plugins are now gone, and the plugin manager seems broken as it will not download any plugins via FTP, and manually installing the archives from https://dev.gajim.org/gajim/gajim-plugins/-/wikis/PluginInstallerPlugin fails too.

agh@direwolf.local.:~:1:$ gajim
No translations found
Dirs searched: [PosixPath('/home/agh/.local/share'), PosixPath('.'), PosixPath('/usr/share'), PosixPath('/usr/local/share'), PosixPath('/usr/local/share/gnome')]

(org.gajim.Gajim:50673): Gtk-WARNING **: 09:21:30.048: Could not load a pixbuf from icon theme.
This may indicate that pixbuf loaders or the mime database could not be found.
18/03/2021 09:21:30 (E) gajim.gui.util             Unable to load icon org.gajim.Gajim: g-io-error-quark: Error opening file /usr/local/share/icons/hicolor/64x64/apps/org.gajim.Gajim.png: No such file or directory (1)
18/03/2021 09:21:30 (E) gajim.gui.util             Unable to load icon org.gajim.Gajim: g-io-error-quark: Error opening file /usr/local/share/icons/hicolor/128x128/apps/org.gajim.Gajim.png: No such file or directory (1)
18/03/2021 09:21:30 (W) gajim.plugin_system        Plugin omemo not loaded, newer version of gajim required: 1.0.99 <= 1.3.1 <= 1.1.90
18/03/2021 09:21:30 (W) gajim.plugin_system        No max_gajim_version found for pgp
18/03/2021 09:21:30 (W) gajim.plugin_system        Plugin anti_spam not loaded, newer version of gajim required: 1.0.99 <= 1.3.1 <= 1.1.90
18/03/2021 09:21:30 (W) gajim.plugin_system        Plugin openpgp not loaded, newer version of gajim required: 1.0.90 <= 1.3.1 <= 1.1.99
18/03/2021 09:21:30 (W) gajim.plugin_system        Plugin syntax_highlight not loaded, newer version of gajim required: 1.1.0 <= 1.3.1 <= 1.1.90
18/03/2021 09:21:55 (W) gajim.gui.notification     Notifications D-Bus not available: g-io-error-quark: Error calling StartServiceByName for org.freedesktop.Notifications: Timeout was reached (24)
18/03/2021 09:28:28 (W) gajim.plugin_system        Plugin plugin_installer not loaded, newer version of gajim required: 1.4.0.dev1 <= 1.3.1 <= 1.4.90
18/03/2021 09:28:28 (W) gajim.plugin_system        Error while installing from zip
18/03/2021 09:29:10 (W) gajim.plugin_system        Plugin plugin_installer not loaded, newer version of gajim required: 1.1.91 <= 1.3.1 <= 1.2.90
18/03/2021 09:29:10 (W) gajim.plugin_system        Error while installing from zip


agh@direwolf.local.:~:2:$ pkg info gajim
gajim-1.3.1_1
Name           : gajim
Version        : 1.3.1_1
Installed on   : Sat Mar 13 20:42:02 2021 AWST
Origin         : net-im/gajim
Architecture   : FreeBSD:14:*
Prefix         : /usr/local
Categories     : net-im
Licenses       : GPLv3
Maintainer     : rm@FreeBSD.org
WWW            : https://gajim.org/
Comment        : GTK+ Jabber client
Options        :
        DBUS           : on
        DOCS           : on
        OMEMO          : on
        SPELL          : on
Annotations    :
        cpe            : cpe:2.3:a:gajim:gajim:1.3.1:::::freebsd14:x64:1
        repo_type      : binary
        repository     : direwolf
Flat size      : 18.8MiB
[removed remaining pkg info output]
Comment 25 commit-hook freebsd_committer freebsd_triage 2021-03-18 09:34:16 UTC
A commit references this bug:

Author: rm
Date: Thu Mar 18 09:33:45 UTC 2021
New revision: 568728
URL: https://svnweb.freebsd.org/changeset/ports/568728

Log:
  net-im/gajim: update to 1.3.1-2

  upstream reuploaded the release with plugin installer included.
  Plugins list/install was broken in 1.3.1

  PR:		248559
  Reported by:	Alastair Hogge <agh@riseup.net>

Changes:
  head/net-im/gajim/Makefile
  head/net-im/gajim/distinfo
Comment 26 Ruslan Makhmatkhanov freebsd_committer freebsd_triage 2021-03-18 09:35:51 UTC
(In reply to Alastair Hogge from comment #24)
Thanks for heads up. Now it's clear what was the difference between 1.3.1 and 1.3.1-2 - they added plugin installer into the new tarball. Now it's in ports, just checked that the plugin installer is functional.
Comment 27 Alastair Hogge 2021-03-18 13:38:52 UTC
Wow that was quick. Thank you very muchly, Ruslan.