Bug 248681 - archivers/par2cmdline - changing upstream
Summary: archivers/par2cmdline - changing upstream
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Ganael LAPLANCHE
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-08-16 04:10 UTC by Paul Holmanskikh
Modified: 2020-08-19 10:15 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (martymac)


Attachments
Port diff ( I hope i done it right) (6.05 KB, patch)
2020-08-16 04:10 UTC, Paul Holmanskikh
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Holmanskikh 2020-08-16 04:10:11 UTC
Created attachment 217249 [details]
Port diff ( I hope i done it right)

curent2cmdline is using old SourceForge repository which is long time dead.

Active development seems to be moved to Github , https://github.com/Parchive/par2cmdline

I changed your port to use new upstream and was able to compile tool without any FreeBSD specific patches to code.

New version also command line compatible from old one.  So it should be drop down replacement for old par2. I tested it against archives created by previous version, no problems there.

I run some test against archive build by old par2 and verification and recovery  
works just fine.  It is not in any way comprehensive test.  New code has some tests included, but I was not able to run them.  shell scripts need some patching. 

I have attached diff to ports files.
Comment 1 Paul Holmanskikh 2020-08-16 11:34:17 UTC
Tests are actually work, it was just me not running them in right way. 

par2cmdline-0.8.1]$ make check

============================================================================
Testsuite summary for par2cmdline 0.8.1
============================================================================
# TOTAL: 29
# PASS:  29
# SKIP:  0
# XFAIL: 0
# FAIL:  0
# XPASS: 0
# ERROR: 0
============================================================================

But i"m not sure how to integrate them to port.
Comment 2 commit-hook freebsd_committer 2020-08-19 10:11:36 UTC
A commit references this bug:

Author: martymac
Date: Wed Aug 19 10:10:39 UTC 2020
New revision: 545299
URL: https://svnweb.freebsd.org/changeset/ports/545299

Log:
  Change upstream and update to much newer version 0.8.1

  A test target has also been added to the port.

  Changelog: https://github.com/Parchive/par2cmdline/blob/master/ChangeLog

  PR:		248681
  Submitted by:	Paul Holmanskikh <freebsd@pkholm.com>

Changes:
  head/archivers/par2cmdline/Makefile
  head/archivers/par2cmdline/distinfo
  head/archivers/par2cmdline/files/patch-Makefile.am
  head/archivers/par2cmdline/files/patch-par2creatorsourcefile.cpp
  head/archivers/par2cmdline/files/patch-par2fileformat.h
  head/archivers/par2cmdline/files/patch-reedsolomon.cpp
  head/archivers/par2cmdline/pkg-descr
Comment 3 Ganael LAPLANCHE freebsd_committer 2020-08-19 10:15:30 UTC
Hi Paul,

The patch has been committed with minor changes, thanks a lot for your report!

I've also enabled the test target (it can be used by running 'make test' in the port's directory).

Best regards,

Ganael.