Bug 248721 - audio/hydrogen Fix build with LIBTAR option
Summary: audio/hydrogen Fix build with LIBTAR option
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Alexey Dokuchaev
URL:
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2020-08-18 09:42 UTC by Shane
Modified: 2020-10-26 08:27 UTC (History)
1 user (show)

See Also:
FreeBSD: maintainer-feedback+
koobs: merge-quarterly?

Attachments
extra patch for audio/hydrogen (841 bytes, text/plain)
2020-08-18 09:42 UTC, Shane 		FreeBSD: maintainer-approval+
Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Shane 2020-08-18 09:42:09 UTC 
Created attachment 217304 [details]
extra patch for audio/hydrogen

audio/hydrogen has an option to choose between libtar and libarchive. The libtar option currently fails, this patch fixes the libtar build.

See https://github.com/hydrogen-music/hydrogen/issues/928
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2020-08-18 11:15:30 UTC 
^Triage: Maintainer-feedback flag (+) not required unless requested (?) first
Comment 2 Shane 2020-08-19 03:04:34 UTC 
Is that for the report or the patch? or both.
Comment 3 commit-hook freebsd_committer freebsd_triage 2020-10-26 08:24:26 UTC 
A commit references this bug:

Author: danfe
Date: Mon Oct 26 08:23:41 UTC 2020
New revision: 553324
URL: https://svnweb.freebsd.org/changeset/ports/553324

Log:
  Unbreak the build against non-default LIBTAR option.

  PR:	248721

Changes:
  head/audio/hydrogen/files/patch-src_gui_src_SoundLibrary_SoundLibraryExportDialog.cpp
Comment 4 Alexey Dokuchaev freebsd_committer freebsd_triage 2020-10-26 08:27:13 UTC 
Patch added with ports r553324, thank you.