Bug 248742 - net/netatalk3: Fix build with -fno-common (clang 11 and gcc 10)
Summary: net/netatalk3: Fix build with -fno-common (clang 11 and gcc 10)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Joe Marcus Clarke
Depends on:
Blocks: 248756
  Show dependency treegraph
Reported: 2020-08-18 21:12 UTC by Dimitry Andric
Modified: 2020-08-29 00:42 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (marcus)
koobs: merge-quarterly?

Fix build with -fno-common (clang 11 and gcc 10) (947 bytes, patch)
2020-08-18 21:12 UTC, Dimitry Andric
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitry Andric freebsd_committer 2020-08-18 21:12:03 UTC
Created attachment 217327 [details]
Fix build with -fno-common (clang 11 and gcc 10)

In base r364284, I imported clang 11 into head. Like gcc 10, it now defaults to -fno-common, meaning that duplicated global symbols will most likely lead to link errors. Here is a patch to fix this port's duplicated global symbols.
Comment 1 Kyle Evans freebsd_committer 2020-08-29 00:42:44 UTC
Looks like marcus fixed this in ports r545827 and ports r546083. Closing as FIXED- thanks!