Bug 248823 - sysutils/htop: Fix build with '-fno-common'
Summary: sysutils/htop: Fix build with '-fno-common'
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Niclas Zeising
URL:
Keywords:
Depends on:
Blocks: 248756
  Show dependency treegraph
 
Reported: 2020-08-22 06:50 UTC by Yasuhiro KIMURA
Modified: 2020-08-22 08:35 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (gaod)


Attachments
Patch file (2.27 KB, patch)
2020-08-22 06:50 UTC, Yasuhiro KIMURA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yasuhiro KIMURA 2020-08-22 06:50:49 UTC
Created attachment 217436 [details]
Patch file

Fix build with '-fno-common', default of GCC 10 and Clang 11.
Comment 1 commit-hook freebsd_committer 2020-08-22 08:26:27 UTC
A commit references this bug:

Author: zeising
Date: Sat Aug 22 08:25:51 UTC 2020
New revision: 545744
URL: https://svnweb.freebsd.org/changeset/ports/545744

Log:
  sysutils/htop: Fix build with -fno-common

  Fix the build of sysutils/htop with -fno-common, which is the default in
  llvm 11 (and gcc 10)

  PR:		248823
  Submitted by:	Yasuhiro KIMURA
  MFH:		2020Q3 (iplicit, -fno-common fixes, ok by joenum)

Changes:
  head/sysutils/htop/files/patch-CRT.h
  head/sysutils/htop/files/patch-freebsd_FreeBSDProcessList.c
  head/sysutils/htop/files/patch-freebsd_FreeBSDProcessList.h
Comment 2 Niclas Zeising freebsd_committer 2020-08-22 08:26:58 UTC
Committed, I'll merge it to Q3 in a bit.
Comment 3 commit-hook freebsd_committer 2020-08-22 08:34:30 UTC
A commit references this bug:

Author: zeising
Date: Sat Aug 22 08:34:21 UTC 2020
New revision: 545749
URL: https://svnweb.freebsd.org/changeset/ports/545749

Log:
  MFH: r545744

  sysutils/htop: Fix build with -fno-common

  Fix the build of sysutils/htop with -fno-common, which is the default in
  llvm 11 (and gcc 10)

  PR:		248823
  Submitted by:	Yasuhiro KIMURA

  Approved by:	ports-secteam (joenum, implicit, -fno-common fixes)

Changes:
_U  branches/2020Q3/
  branches/2020Q3/sysutils/htop/files/patch-CRT.h
  branches/2020Q3/sysutils/htop/files/patch-freebsd_FreeBSDProcessList.c
  branches/2020Q3/sysutils/htop/files/patch-freebsd_FreeBSDProcessList.h
Comment 4 Niclas Zeising freebsd_committer 2020-08-22 08:35:05 UTC
All done and merged, thanks!