Bug 248852 - print/gtklp: fix build with -fno-common
Summary: print/gtklp: fix build with -fno-common
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Kyle Evans
URL: http://beefy18.nyi.freebsd.org/data/h...
Keywords: buildisok
Depends on:
Blocks: 248756
  Show dependency treegraph
 
Reported: 2020-08-23 17:27 UTC by m.ne
Modified: 2020-08-29 01:42 UTC (History)
2 users (show)

See Also:
kevans: merge-quarterly+


Attachments
Patch for fixing print/gtklp build with -fno-common (3.94 KB, patch)
2020-08-23 17:27 UTC, m.ne
m.ne: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description m.ne 2020-08-23 17:27:31 UTC
Created attachment 217457 [details]
Patch for fixing print/gtklp build with -fno-common
Comment 1 Automation User 2020-08-23 18:13:35 UTC
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/181039905
Comment 2 commit-hook freebsd_committer 2020-08-29 01:41:09 UTC
A commit references this bug:

Author: kevans
Date: Sat Aug 29 01:40:30 UTC 2020
New revision: 546861
URL: https://svnweb.freebsd.org/changeset/ports/546861

Log:
  print/gtklp: fix build with -fno-common

  Just a couple of duplicate symbols here.

  PR:		248852
  MFH:		2020Q3 (-fno-common build fix)

Changes:
  head/print/gtklp/files/
  head/print/gtklp/files/patch-gtklp_gtklp.c
  head/print/gtklp/files/patch-gtklp_gtklp__functions.c
  head/print/gtklp/files/patch-gtklpq_gtklpq.c
  head/print/gtklp/files/patch-libgtklp_libgtklp.h
Comment 3 Kyle Evans freebsd_committer 2020-08-29 01:42:09 UTC
Committed, thanks!
Comment 4 commit-hook freebsd_committer 2020-08-29 01:42:10 UTC
A commit references this bug:

Author: kevans
Date: Sat Aug 29 01:41:11 UTC 2020
New revision: 546862
URL: https://svnweb.freebsd.org/changeset/ports/546862

Log:
  MFH: r546861

  print/gtklp: fix build with -fno-common

  Just a couple of duplicate symbols here.

  PR:		248852

  Approved by:	ports-secteam (implicit, -fno-common build fix)

Changes:
_U  branches/2020Q3/
  branches/2020Q3/print/gtklp/files/