Bug 248858 - www/tt-rss: Installs incorrect rc.d script when PGSQL=OFF
Summary: www/tt-rss: Installs incorrect rc.d script when PGSQL=OFF
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords: needs-qa, regression
Depends on:
Blocks:
 
Reported: 2020-08-23 20:31 UTC by Vadim Belman
Modified: 2020-09-01 10:02 UTC (History)
2 users (show)

See Also:
dereks: maintainer-feedback+
koobs: merge-quarterly-


Attachments
Fix commenting of ttrssd.in between mysql and pgsql (853 bytes, patch)
2020-08-23 22:26 UTC, Derek Schrock
dereks: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vadim Belman 2020-08-23 20:31:02 UTC
With the latest update tt-rss port installs a rc.d script in which sets two different CHECK_CMD variables. The first is checking for mysql status, the second – for postgresql. The corresponding lines in port's files/ttrssd.in template look like:

%%MYSQL%%CHECK_CMD="%%LOCALBASE%%/bin/mysqladmin -u mysqld ping"
%%MYSQL%%CHECK_MSG="${name}: mysqladmin command failed; mysql not ready?"
# Waiting for pg_isready when 9.3 is the default
%%PGSQL%%CHECK_CMD="%%LOCALBASE%%/etc/rc.d/postgresql status"
%%PGSQL%%CHECK_MSG="${name}: postgresql status failed; postgresql not ready?"

Now, even though the port is configured to use MySQL, PostgreSQL check overrides it breaking the daemon startup.
Comment 1 Derek Schrock 2020-08-23 22:09:53 UTC
Ok I think I see the issue.  The PSQL_VAR_OFF is incorrect.  Should be PGSQL_..

Must have had it correct locally but changed it between commits.
Comment 2 Derek Schrock 2020-08-23 22:26:56 UTC
Created attachment 217469 [details]
Fix commenting of ttrssd.in between mysql and pgsql

Fixing the typo in PSQL_VARS_OFF and flip/flopping between options will comment either or now.
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2020-08-24 03:20:25 UTC
@Reporter/Maintainer Is quarterly affected by this?
Comment 4 Derek Schrock 2020-08-24 03:23:05 UTC
It shouldn't no.
It was from 248601.
Comment 5 commit-hook freebsd_committer 2020-09-01 10:02:01 UTC
A commit references this bug:

Author: netchild
Date: Tue Sep  1 10:01:55 UTC 2020
New revision: 547256
URL: https://svnweb.freebsd.org/changeset/ports/547256

Log:
  Fix PGSQL=OFF case.

  Submitted by:	maintainer
  PR:		248858

Changes:
  head/www/tt-rss/Makefile