Bug 248868 - comms/owfs: Update to 3.2p4
Summary: comms/owfs: Update to 3.2p4
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-ports-bugs (Nobody)
URL: https://github.com/owfs/owfs/releases...
Keywords: buildisok, needs-qa
Depends on:
Blocks:
 
Reported: 2020-08-24 06:30 UTC by Johan Ström
Modified: 2020-10-01 20:56 UTC (History)
1 user (show)

See Also:


Attachments
version change (2.00 KB, patch)
2020-08-24 06:30 UTC, Johan Ström
no flags Details | Diff
Updates to 2.3p4 and removes USE_GITHUB (2.18 KB, patch)
2020-09-08 08:31 UTC, Johan Ström
no flags Details | Diff
Update to 3.2p4 & distfile + remove python, owtraffic options (5.80 KB, patch)
2020-10-01 20:56 UTC, Johan Ström
johan: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Johan Ström 2020-08-24 06:30:04 UTC
Created attachment 217478 [details]
version change

owfs 3.2p4 have been released, which among other things fixes a FreeBSD build bug. Attached patch makes the port use the latest version (almost only version number changes in port)
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2020-08-24 12:05:30 UTC
^Triage: 

- [tags] in issue Titles are deprecated
-  If there is a changelog or release notes URL available for this version, please add it to the URL field
Comment 2 Automation User 2020-08-24 12:29:30 UTC
Build info is available at https://gitlab.com/swills/freebsd-ports/pipelines/181297861
Comment 3 daniel.engberg.lists 2020-08-30 17:14:05 UTC
Hi,

Please use upstream release archive instead of GitHub (5.4.3 in Porter's Handbook).
https://github.com/owfs/owfs/releases/tag/v3.2p4
Comment 4 Johan Ström 2020-09-01 07:55:38 UTC
Sorry, I'm not following. I thought USE_GITHUB with no custom GH_TAGNAME would use the GH release .tar.gz.

Can you please clarify?
Comment 5 daniel.engberg.lists 2020-09-03 14:20:18 UTC
Hi,

No, it's doesn't revert to downloading "assets"
https://svnweb.freebsd.org/ports/head/Mk/bsd.sites.mk?revision=543005&view=markup#l345
Comment 6 Johan Ström 2020-09-07 18:29:05 UTC
Would the following pseudo-patch be correct?

- DISTVERSIONPREFIX=  v
- USE_GITHUB=     yes
..
+ MASTER_SITES = https://github.com/owfs/owfs/releases/download/v${PORTVERSION}/
Comment 7 daniel.engberg.lists 2020-09-07 21:55:17 UTC
According to example 5.4 you should use DISTVERSION as far as I can tell, looks good otherwise.
https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-naming.html
Comment 8 Johan Ström 2020-09-08 07:20:51 UTC
The 'p' in this case indicates patch version 4, not "pre". My understanding from 5.4 is to use DISTVERSION if I want 3.2p4 to be ordered before 3.2, but that is not the case here, 3.2p4 comes after 3.2 and 3.2p3.
Comment 9 daniel.engberg.lists 2020-09-08 08:24:29 UTC
I see, in that case PORTVERSION is the correct variable.
Comment 10 Johan Ström 2020-09-08 08:31:42 UTC
Created attachment 217815 [details]
Updates to 2.3p4 and removes USE_GITHUB

Updated patch attached
Comment 11 daniel.engberg.lists 2020-09-26 16:04:54 UTC
I looked at this a bit closer,

owtraffic is no longer available as a configure switch and should be removed
You can drop autoreconf and gmake from USES= (compiles fine on -CURRENT without)
MASTER_SITES variable should be directly under CATEGORIES variable.
Usage of uthash should be properly specified

Best regards,
Daniel
Comment 12 Johan Ström 2020-10-01 20:56:31 UTC
Created attachment 218454 [details]
Update to 3.2p4 & distfile + remove python, owtraffic options

A new patch attached (against existing port):

* Update 3.2p3 -> 3.2p4
* Change from USE_GITHUB to MASTER_SITES
* Remove OWFS Python bindings, as python2.7 is no longer supported in FreeBSD and owfs python binding does not build with anything else. It is deprecated in favour for pyownet or similar (see https://github.com/owfs/owfs/issues/75 for more details)
* Remove owtraffic as it is now builtin.
* Add uthash build dependency (header-only)

I was not able to remove USES=gmake however, if I did that a bunch of manpages did not get included (which poudriere testport detected and failed).

portlint -A does not complain on anything now, so hopefully Makefile is in order