Created attachment 217479 [details] flags fix Hi, The iflib rewrite forced the promisc flag but it was not reported to the system. Noticed on a stock VM that went into unsolicited promisc mode when dhclient was started during bootup. This also affects CURRENT and is present since 12.0, but marking this as a 12.1-RELEASE issue. Patch is attached to restore the previous behaviour. Cheers, Franco
Thanks for the report and patch Franco
This looks good to me. This would match the behavior of em_set_promisc() in em_init() in the non-iflib version of em(4).
Thanks! Is there any chance to get this into 12.1-RELEASE as errata as well? As a related issue hw.em.sbp changed defaults at the same time: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=248934 Cheers, Franco
I guess I should take care of committing this then? I doubt we'll do a 12.1 errata because 12.2 is so close to release. I can work on getting this merged there.
Sorry, I'm not a FreeBSD committer. 12.2 sounds fine. Thanks!
A commit references this bug: Author: erj Date: Tue Sep 15 21:07:30 UTC 2020 New revision: 365776 URL: https://svnweb.freebsd.org/changeset/base/365776 Log: e1000: Properly retain promisc flag From Franco: The iflib rewrite forced the promisc flag but it was not reported to the system. Noticed on a stock VM that went into unsolicited promisc mode when dhclient was started during bootup. PR: 248869 Submitted by: Franco Fichtner <franco@opnsense.org> Reviewed by: erj@ MFC after: 3 days Changes: head/sys/dev/e1000/if_em.c
A commit references this bug: Author: erj Date: Mon Sep 21 22:52:58 UTC 2020 New revision: 365983 URL: https://svnweb.freebsd.org/changeset/base/365983 Log: MFC r365774 and r365776 These two commits fix issues in em(4)/igb(4): - Fix define and includes with RSS option enabled - Properly retain promisc flag in init PR: 249191, 248869 MFC after: 1 day Changes: _U stable/12/ stable/12/sys/dev/e1000/if_em.c stable/12/sys/dev/e1000/if_em.h
A commit references this bug: Author: erj Date: Wed Sep 23 23:56:50 UTC 2020 New revision: 366097 URL: https://svnweb.freebsd.org/changeset/base/366097 Log: MFS r365983 Contains fixes for issues in em(4)/igb(4): - Fix define and includes with RSS option enabled - Properly retain promisc flag in init PR: 249191, 248869 Approved by: re (gjb@) Changes: _U releng/12.2/ releng/12.2/sys/dev/e1000/if_em.c releng/12.2/sys/dev/e1000/if_em.h
^Triage : If there are no further commits or merges, please resolve -> FIXED Thanks Eric
Thanks for the patch, Franco.