Bug 248916 - www/p5-Starman -- provided init script has coding errors
Summary: www/p5-Starman -- provided init script has coding errors
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jun Kuriyama
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-08-25 21:11 UTC by James B. Byrne
Modified: 2020-08-26 11:36 UTC (History)
1 user (show)

See Also:
linimon: maintainer-feedback? (kuriyama)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description James B. Byrne 2020-08-25 21:11:33 UTC
The provided init script contains these lines:

starman_enable=${starman_enable-"NO"}
starman_config=${starman_config-"/usr/local/etc/starman.psgi"}
starman_user=${starman_user-"www"}
starman_group=${starman_group-"www"}

The comparison operator is missing the colon : 

These should be 

starman_enable=${starman_enable:-"NO"}
starman_config=${starman_config:-"/usr/local/etc/starman.psgi"}
starman_user=${starman_user:-"www"}
starman_group=${starman_group:-"www"}

I have already corrected this on my suystem so one or more of these may be correct as distributed but the first two are certainly wrong as shipped.
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2020-08-26 11:36:08 UTC
^Triage: fix Summary and assign.